Thread: [HACKERS] [doc fix] Really trivial fix for BRIN documentation

[HACKERS] [doc fix] Really trivial fix for BRIN documentation

From
"Tsunakawa, Takayuki"
Date:
Hello,

This is just a correction from "index" to "table".  I was a bit confused when I first read this part.


Regards
Takayuki Tsunakawa


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

Re: [HACKERS] [doc fix] Really trivial fix for BRIN documentation

From
Simon Riggs
Date:
On 21 February 2017 at 06:34, Tsunakawa, Takayuki
<tsunakawa.takay@jp.fujitsu.com> wrote:
> Hello,
>
> This is just a correction from "index" to "table".  I was a bit confused when I first read this part.

Pushed, but using "heap" rather than "table", for clarity. Thanks for the patch.

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Re: [HACKERS] [doc fix] Really trivial fix for BRIN documentation

From
"Tsunakawa, Takayuki"
Date:
From: Simon Riggs [mailto:simon@2ndquadrant.com]
> Pushed, but using "heap" rather than "table", for clarity. Thanks for the
> patch.

Thank you for responding so quickly.  I'm comfortable with "heap."  On the other hand, src/backend/access/brin/README
uses"table" as follows.  Second, I thought users would feel more familiar with the general term "table."  Third, I
supposedPostgreSQL might add support for other structures for tables than heap in the future, like SQL Server provides
heap(non-clustered table) and clustered tables.
 

At index creation time, the whole table is scanned; for each page range the
summarizing values of each indexed column and nulls bitmap are collected and
stored in the index.

I should have written the reason I chose "table."  Anyway, I'm OK with heap.

Regards
Takayuki Tsunakawa