Thread: [HACKERS] Re: [COMMITTERS] pgsql: Remove all references to "xlog" fromSQL-callable functions in p
[HACKERS] Re: [COMMITTERS] pgsql: Remove all references to "xlog" fromSQL-callable functions in p
From
Fujii Masao
Date:
On Fri, Feb 10, 2017 at 5:36 AM, Robert Haas <rhaas@postgresql.org> wrote: > Remove all references to "xlog" from SQL-callable functions in pg_proc. > > Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog > directory to pg_wal. To make things consistent, and because "xlog" is > terrible terminology for either "transaction log" or "write-ahead log" > rename all SQL-callable functions that contain "xlog" in the name to > instead contain "wal". (Note that this may pose an upgrade hazard for > some users.) There are still some mentions to "xlog" in the doc. Maybe we should replace them with "wal" as the attached patch does. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Attachment
[HACKERS] Re: [COMMITTERS] pgsql: Remove all references to "xlog" fromSQL-callable functions in p
From
Robert Haas
Date:
On Mon, Feb 13, 2017 at 11:43 AM, Fujii Masao <masao.fujii@gmail.com> wrote: > On Fri, Feb 10, 2017 at 5:36 AM, Robert Haas <rhaas@postgresql.org> wrote: >> Remove all references to "xlog" from SQL-callable functions in pg_proc. >> >> Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog >> directory to pg_wal. To make things consistent, and because "xlog" is >> terrible terminology for either "transaction log" or "write-ahead log" >> rename all SQL-callable functions that contain "xlog" in the name to >> instead contain "wal". (Note that this may pose an upgrade hazard for >> some users.) > > There are still some mentions to "xlog" in the doc. Maybe we should replace > them with "wal" as the attached patch does. +1. Patch looks good to me. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
[HACKERS] Re: [COMMITTERS] pgsql: Remove all references to "xlog" fromSQL-callable functions in p
From
Fujii Masao
Date:
On Tue, Feb 14, 2017 at 2:06 AM, Robert Haas <robertmhaas@gmail.com> wrote: > On Mon, Feb 13, 2017 at 11:43 AM, Fujii Masao <masao.fujii@gmail.com> wrote: >> On Fri, Feb 10, 2017 at 5:36 AM, Robert Haas <rhaas@postgresql.org> wrote: >>> Remove all references to "xlog" from SQL-callable functions in pg_proc. >>> >>> Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog >>> directory to pg_wal. To make things consistent, and because "xlog" is >>> terrible terminology for either "transaction log" or "write-ahead log" >>> rename all SQL-callable functions that contain "xlog" in the name to >>> instead contain "wal". (Note that this may pose an upgrade hazard for >>> some users.) >> >> There are still some mentions to "xlog" in the doc. Maybe we should replace >> them with "wal" as the attached patch does. > > +1. Patch looks good to me. Thanks! Pushed. Regards, -- Fujii Masao
Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove all references to "xlog"from SQL-callable functions in p
From
Michael Paquier
Date:
On Tue, Feb 14, 2017 at 2:31 AM, Fujii Masao <masao.fujii@gmail.com> wrote: > On Tue, Feb 14, 2017 at 2:06 AM, Robert Haas <robertmhaas@gmail.com> wrote: >> On Mon, Feb 13, 2017 at 11:43 AM, Fujii Masao <masao.fujii@gmail.com> wrote: >>> On Fri, Feb 10, 2017 at 5:36 AM, Robert Haas <rhaas@postgresql.org> wrote: >>>> Remove all references to "xlog" from SQL-callable functions in pg_proc. >>>> >>>> Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog >>>> directory to pg_wal. To make things consistent, and because "xlog" is >>>> terrible terminology for either "transaction log" or "write-ahead log" >>>> rename all SQL-callable functions that contain "xlog" in the name to >>>> instead contain "wal". (Note that this may pose an upgrade hazard for >>>> some users.) >>> >>> There are still some mentions to "xlog" in the doc. Maybe we should replace >>> them with "wal" as the attached patch does. >> >> +1. Patch looks good to me. > > Thanks! Pushed. It seems like the previous review I provided for the set of renaming patches has been ignored: https://www.postgresql.org/message-id/CAB7nPqSm=PNSe3EfvnEResdFzpQMcXXgapFBcF=EFdxVW4=fDQ@mail.gmail.com Good that somebody else checked... -- Michael
Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove all references to "xlog"from SQL-callable functions in p
From
Robert Haas
Date:
On Mon, Feb 13, 2017 at 5:00 PM, Michael Paquier <michael.paquier@gmail.com> wrote: > It seems like the previous review I provided for the set of renaming > patches has been ignored: > https://www.postgresql.org/message-id/CAB7nPqSm=PNSe3EfvnEResdFzpQMcXXgapFBcF=EFdxVW4=fDQ@mail.gmail.com > Good that somebody else checked... Sorry about that, Michael. That was careless of me. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove all references to "xlog"from SQL-callable functions in p
From
Michael Paquier
Date:
On Wed, Feb 15, 2017 at 2:08 AM, Robert Haas <robertmhaas@gmail.com> wrote: > On Mon, Feb 13, 2017 at 5:00 PM, Michael Paquier > <michael.paquier@gmail.com> wrote: >> It seems like the previous review I provided for the set of renaming >> patches has been ignored: >> https://www.postgresql.org/message-id/CAB7nPqSm=PNSe3EfvnEResdFzpQMcXXgapFBcF=EFdxVW4=fDQ@mail.gmail.com >> Good that somebody else checked... > > Sorry about that, Michael. That was careless of me. No problem. Thanks. -- Michael