Thread: [pgadmin-hackers] [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries
[pgadmin-hackers] [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries
From
Murtuza Zabuawala
Date:
Hi,
PFA patch to fix the issue with Graphical Explain plan functionality which was breaking for INSERT/UPDATE/DELETE explain plans.
RM#2133
Issue: It was due to typo in imageMapper object.
Please review.
--
Regards,
Attachment
Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries
From
Dave Page
Date:
Hi On Mon, Feb 6, 2017 at 5:40 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue with Graphical Explain plan functionality which > was breaking for INSERT/UPDATE/DELETE explain plans. > RM#2133 > > Issue: It was due to typo in imageMapper object. > > Please review. It's a definite improvement, but still isn't quite right - see the attached screenshot for example; the node name should be pem.agent shouldn't it (or 'Delete' or 'Delete from pem.agent')? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Attachment
Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix graphical explain for Insert/Update/Delete quries
From
Murtuza Zabuawala
Date:
Hi Dave,
With Same query I am getting proper output same as pgAdmin3.
Can you hard refresh browser & try again?
--
Regards,
On Mon, Feb 6, 2017 at 3:31 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi
On Mon, Feb 6, 2017 at 5:40 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue with Graphical Explain plan functionality which
> was breaking for INSERT/UPDATE/DELETE explain plans.
> RM#2133
>
> Issue: It was due to typo in imageMapper object.
>
> Please review.
It's a definite improvement, but still isn't quite right - see the
attached screenshot for example; the node name should be pem.agent
shouldn't it (or 'Delete' or 'Delete from pem.agent')?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix graphical explain forInsert/Update/Delete quries
From
Dave Page
Date:
On Mon, Feb 6, 2017 at 10:33 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > With Same query I am getting proper output same as pgAdmin3. > Can you hard refresh browser & try again? That's really weird - it's working now. It was a single-file change, and when I tested it went from failing to display the node properly at all, to displaying it with the incorrect label, so it must have loaded an update. Oh well - it works now, so patch applied. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company