Thread: [pgadmin-hackers] [pgAdmin4][Patch]: RM#2015 - Trigger issues
Hi,
Please find attached patch file for the fix of RM#2015.
Below additional issues are fixed along with description provided in RM.
- When user update any of the parameter - trigger gets disappear from browser tree. To make it visible user has to do refresh.
- Edit Mode - 'Row level' trigger was not allowed to edit for "inline edb-spl" trigger function, even though "Row Trigger" is enabled.
- SQL was not generated properly when user change 'Row Trigger', Fires and events.
- Edit Mode - Fires and Events should be allowed to edit for "inline edb-spl" function mentioned with Code in description.
- Edit Mode - For trigger, if user edit parameters like Fires, Events, Code, Row trigger etc. then new OID is getting generated so we should fetch and return new OID in response rather then old trigger OID.
Do review it and let us know for comments.
Thanks,
Neel Patel
Attachment
Thanks, patch applied. On Fri, Jan 27, 2017 at 7:06 PM, Neel Patel <neel.patel@enterprisedb.com> wrote: > Hi, > > Please find attached patch file for the fix of RM#2015. > > Below additional issues are fixed along with description provided in RM. > > When user update any of the parameter - trigger gets disappear from browser > tree. To make it visible user has to do refresh. > Edit Mode - 'Row level' trigger was not allowed to edit for "inline edb-spl" > trigger function, even though "Row Trigger" is enabled. > SQL was not generated properly when user change 'Row Trigger', Fires and > events. > Edit Mode - Fires and Events should be allowed to edit for "inline edb-spl" > function mentioned with Code in description. > Edit Mode - For trigger, if user edit parameters like Fires, Events, Code, > Row trigger etc. then new OID is getting generated so we should fetch and > return new OID in response rather then old trigger OID. > > Do review it and let us know for comments. > > Thanks, > Neel Patel > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
For the record, the author was Neel, not Murtuza as I put in the commit message. Sorry Neel! On Mon, Jan 30, 2017 at 1:06 PM, Dave Page <dpage@pgadmin.org> wrote: > Thanks, patch applied. > > On Fri, Jan 27, 2017 at 7:06 PM, Neel Patel <neel.patel@enterprisedb.com> wrote: >> Hi, >> >> Please find attached patch file for the fix of RM#2015. >> >> Below additional issues are fixed along with description provided in RM. >> >> When user update any of the parameter - trigger gets disappear from browser >> tree. To make it visible user has to do refresh. >> Edit Mode - 'Row level' trigger was not allowed to edit for "inline edb-spl" >> trigger function, even though "Row Trigger" is enabled. >> SQL was not generated properly when user change 'Row Trigger', Fires and >> events. >> Edit Mode - Fires and Events should be allowed to edit for "inline edb-spl" >> function mentioned with Code in description. >> Edit Mode - For trigger, if user edit parameters like Fires, Events, Code, >> Row trigger etc. then new OID is getting generated so we should fetch and >> return new OID in response rather then old trigger OID. >> >> Do review it and let us know for comments. >> >> Thanks, >> Neel Patel >> >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company