Thread: [COMMITTERS] pgsql: Fill in no_priv_msg for publications and subscriptions
[COMMITTERS] pgsql: Fill in no_priv_msg for publications and subscriptions
From
Peter Eisentraut
Date:
Fill in no_priv_msg for publications and subscriptions Even though these messages are not used yet, we should keep the list complete. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/e630faacd8a0c998db105a7d3fca063eb29b0eea Modified Files -------------- src/backend/catalog/aclchk.c | 4 ++++ 1 file changed, 4 insertions(+)
Re: [COMMITTERS] pgsql: Fill in no_priv_msg for publications andsubscriptions
From
Alvaro Herrera
Date:
Peter Eisentraut wrote: > Fill in no_priv_msg for publications and subscriptions > > Even though these messages are not used yet, we should keep the list > complete. Hmm, should we add a StaticAssert() somewhere that lengthof(msg_no_priv) is somehow consistent with the AclObjectKind enum? Probably in aclcheck_error() itself. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Re: [COMMITTERS] pgsql: Fill in no_priv_msg for publications andsubscriptions
From
Peter Eisentraut
Date:
On 1/26/17 4:46 PM, Alvaro Herrera wrote: > Peter Eisentraut wrote: >> Fill in no_priv_msg for publications and subscriptions >> >> Even though these messages are not used yet, we should keep the list >> complete. > > Hmm, should we add a StaticAssert() somewhere that lengthof(msg_no_priv) > is somehow consistent with the AclObjectKind enum? Probably in > aclcheck_error() itself. Maybe, but I think it's not that important, because an actual test of the permissions will easily show when something is missing or wrong. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Re: [COMMITTERS] pgsql: Fill in no_priv_msg for publications andsubscriptions
From
Alvaro Herrera
Date:
Peter Eisentraut wrote: > On 1/26/17 4:46 PM, Alvaro Herrera wrote: > > Peter Eisentraut wrote: > >> Fill in no_priv_msg for publications and subscriptions > >> > >> Even though these messages are not used yet, we should keep the list > >> complete. > > > > Hmm, should we add a StaticAssert() somewhere that lengthof(msg_no_priv) > > is somehow consistent with the AclObjectKind enum? Probably in > > aclcheck_error() itself. > > Maybe, but I think it's not that important, because an actual test of > the permissions will easily show when something is missing or wrong. True. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services