Thread: Re: [HACKERS] [COMMITTERS] pgsql: Reindent table partitioning code.
On Tue, Jan 24, 2017 at 10:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Robert Haas <rhaas@postgresql.org> writes: >> Reindent table partitioning code. > > Oh, thank you, I was starting to get annoyed with that too. Glad you like. The pgindent damage introduced by the logical replication commits is even more extensive, but I didn't want to touch that without discussion. Peter might want to look for a time when not too many patches are pending to do something similar, though. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On 1/24/17 10:51 AM, Robert Haas wrote: > On Tue, Jan 24, 2017 at 10:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Robert Haas <rhaas@postgresql.org> writes: >>> Reindent table partitioning code. >> >> Oh, thank you, I was starting to get annoyed with that too. > > Glad you like. The pgindent damage introduced by the logical > replication commits is even more extensive, but I didn't want to touch > that without discussion. Peter might want to look for a time when not > too many patches are pending to do something similar, though. Can you give me an example of a file or area that looks bad now? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Thu, Jan 26, 2017 at 10:16 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > On 1/24/17 10:51 AM, Robert Haas wrote: >> On Tue, Jan 24, 2017 at 10:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >>> Robert Haas <rhaas@postgresql.org> writes: >>>> Reindent table partitioning code. >>> >>> Oh, thank you, I was starting to get annoyed with that too. >> >> Glad you like. The pgindent damage introduced by the logical >> replication commits is even more extensive, but I didn't want to touch >> that without discussion. Peter might want to look for a time when not >> too many patches are pending to do something similar, though. > > Can you give me an example of a file or area that looks bad now? What I did was just run pgindent on the whole tree and then undid all the stuff that was unrelated to table partitioning with 'git checkout' and/or 'git checkout -p'. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company