Thread: [HACKERS] createdb warnings on OS X

I'm seeing the following warnings on a recent checkout. make check still 
passes fine though...

> ccache clang -Qunused-arguments -fcolor-diagnostics -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement-Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv
-Wno-unused-command-line-argument-O2 -I../../../src/interfaces/libpq -I../../../src/include
-I/opt/local/include/libxml2  -c -o createdb.o createdb.c -MMD -MP -MF .deps/createdb.Po
 
> input.c:81:3: warning: implicit declaration of function 'rl_reset_screen_size' is invalid in C99
[-Wimplicit-function-declaration]
>                 rl_reset_screen_size();
>                 ^
> input.c:455:13: warning: implicit declaration of function 'append_history' is invalid in C99
[-Wimplicit-function-declaration]
>                         errnum = append_history(nlines, fname);
>                                  ^
> 2 warnings generated.

> decibel@decina:[17:04]~/pgsql/HEAD (temp *$%)$uname -a
> Darwin decina.local 15.6.0 Darwin Kernel Version 15.6.0: Wed Nov  2 20:30:56 PDT 2016;
root:xnu-3248.60.11.1.2~2/RELEASE_X86_64x86_64
 
> decibel@decina:[17:04]~/pgsql/HEAD (temp *$%)$echo $CC
> ccache clang -Qunused-arguments -fcolor-diagnostics
> decibel@decina:[17:04]~/pgsql/HEAD (temp *$%)$head config.log|grep './conf'
>   $ ./configure --with-libxml --with-tcl --with-perl --with-python --enable-depend --enable-dtrace --enable-tap-tests
--prefix=/Users/decibel/pgsql/HEAD/i/i--with-pgport=5555 -C
 
> decibel@decina:[17:05]~/pgsql/HEAD (temp *$%)$

> grep HAVE_RL_RESET_SCREEN_SIZE config.log
> | #define HAVE_RL_RESET_SCREEN_SIZE 1
> #define HAVE_RL_RESET_SCREEN_SIZE 1
> decibel@decina:[17:08]~/pgsql/HEAD (temp *$%)$grep HISTORY config.log
> | #define HAVE_READLINE_HISTORY_H 1
> | #define HAVE_APPEND_HISTORY 1
> | #define HAVE_HISTORY_TRUNCATE_FILE 1
> #define HAVE_READLINE_HISTORY_H 1
> #define HAVE_APPEND_HISTORY 1
> #define HAVE_HISTORY_TRUNCATE_FILE 1

> git ls -1
> 7c3abe3c92 (HEAD -> temp, origin/master, origin/HEAD, master) Get rid of ParseState.p_value_substitute; use a
columnrefhook instead. [Tom Lane]
 


-- 
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)

Jim Nasby <Jim.Nasby@BlueTreble.com> writes:
> I'm seeing the following warnings on a recent checkout. make check still
> passes fine though...

There's something screwy about your readline installation (or, if you
didn't install GNU readline, about the libedit that OS X supplies).
This is kind of par for the course on OS X, of course.

>> decibel@decina:[17:04]~/pgsql/HEAD (temp *$%)$uname -a
>> Darwin decina.local 15.6.0 Darwin Kernel Version 15.6.0: Wed Nov  2 20:30:56 PDT 2016;
root:xnu-3248.60.11.1.2~2/RELEASE_X86_64x86_64 

I can never remember how Darwin kernel versions map to OS X versions?
But the real question is whether you've got (any vestiges of) a manual
readline installation.
        regards, tom lane

On 1/8/17 6:03 PM, Tom Lane wrote:
>>> decibel@decina:[17:04]~/pgsql/HEAD (temp *$%)$uname -a
>>> Darwin decina.local 15.6.0 Darwin Kernel Version 15.6.0: Wed Nov  2 20:30:56 PDT 2016;
root:xnu-3248.60.11.1.2~2/RELEASE_X86_64x86_64
 
> I can never remember how Darwin kernel versions map to OS X versions?
> But the real question is whether you've got (any vestiges of) a manual
> readline installation.

OS X 10.11.6
From config.log...
configure:13546: ccache clang -Qunused-arguments -fcolor-diagnostics -o 
conftest -Wall -Wmissing-prototypes -Wpointer-arith 
-Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute 
-Wformat-security -fno-strict-aliasing -fwrapv 
-Wno-unused-command-line-argument -O2  -I/opt/local/include/libxml2 
-L/opt/local/lib  conftest.c -lxml2 -lz -lreadline -lm  >&5

I recently discovered things now work even if I don't supply 
--with-includes=/opt/local/include and --with-libraries=/opt/local/lib 
to configure, so maybe that's it.

In any case it doesn't bother me enough to investigate it right now. I 
just wanted to make sure it wasn't something more serious.

Thanks!
-- 
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)