Thread: [pgadmin-hackers] [pgAdmin4][Patch]: RM2039 - Big (numeric) numbers are sometimesrounded up when displayed
[pgadmin-hackers] [pgAdmin4][Patch]: RM2039 - Big (numeric) numbers are sometimesrounded up when displayed
From
Surinder Kumar
Date:
Hi,
Added 'numeric' type into string typecaster to prevent python from rounded up.
Please find attached patch and review.
Thanks,
Surinder Kumar
Attachment
Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM2039 - Big (numeric)numbers are sometimes rounded up when displayed
From
Surinder Kumar
Date:
Hi Dave,
Please find updated patch.
Changes:
1) Add typecaster for numeric and double precision.
2) As numeric data is typecasted into string type, we need not to do parseInt value in javascript.
3) Remove redundant code for registering new types.
On Mon, Jan 9, 2017 at 9:11 AM, Dave Page <dpage@pgadmin.org> wrote:
Hi
On Friday, December 23, 2016, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote: Hi,Added 'numeric' type into string typecaster to prevent python from rounded up.Please find attached patch and review.I'm still seeing rounding with this patch applied - e.g. with:select 12345678901234567890::numericSomething in the JS perhaps?
Attachment
Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM2039 - Big (numeric)numbers are sometimes rounded up when displayed
From
Dave Page
Date:
Thanks, patch applied. On Fri, Feb 24, 2017 at 12:35 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote: > Hi Dave, > > Please find updated patch. > > Changes: > > 1) Add typecaster for numeric and double precision. > > 2) As numeric data is typecasted into string type, we need not to do > parseInt value in javascript. > > 3) Remove redundant code for registering new types. > > > On Mon, Jan 9, 2017 at 9:11 AM, Dave Page <dpage@pgadmin.org> wrote: >> >> Hi >> >> On Friday, December 23, 2016, Surinder Kumar >> <surinder.kumar@enterprisedb.com> wrote: >>> >>> Hi, >>> >>> Added 'numeric' type into string typecaster to prevent python from >>> rounded up. >>> >>> Please find attached patch and review. >> >> >> I'm still seeing rounding with this patch applied - e.g. with: >> >> select 12345678901234567890::numeric >> >> Something in the JS perhaps? >> >> > > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company