Thread: Minor code improvement to postgresGetForeignJoinPaths

Hi,

The last argument of create_foreignscan_path called by postgresGetForeignJoinPaths is
set to NULL, but it would be suitable to set it to NIL because the argument type is List.

Please find attached a patch.

Tatsuro Yamada
NTT Open Source Software Center

On Mon, Oct 24, 2016 at 7:56 AM, Tatsuro Yamada
<yamada.tatsuro@lab.ntt.co.jp> wrote:
> Hi,
>
> The last argument of create_foreignscan_path called by postgresGetForeignJoinPaths is
> set to NULL, but it would be suitable to set it to NIL because the argument type is List.
>
> Please find attached a patch.
>
You are right. Every call except that one is using NIL, so better to
fix it. The pattern was repeated in the recent aggregate pushdown
support. Here's patch to fix create_foreignscan_path() call in
add_foreign_grouping_paths() as well.

--
Best Wishes,
Ashutosh Bapat
EnterpriseDB Corporation
The Postgres Database Company

Hi Ashutosh,

> You are right. Every call except that one is using NIL, so better to
> fix it. The pattern was repeated in the recent aggregate pushdown
> support. Here's patch to fix create_foreignscan_path() call in
> add_foreign_grouping_paths() as well.

Thanks for the review!

Tatsuro Yamada
NTT Open Source Software Center

On Tue, Oct 25, 2016 at 1:59 AM, Tatsuro Yamada
<yamada.tatsuro@lab.ntt.co.jp> wrote:
> Hi Ashutosh,
>> You are right. Every call except that one is using NIL, so better to
>> fix it. The pattern was repeated in the recent aggregate pushdown
>> support. Here's patch to fix create_foreignscan_path() call in
>> add_foreign_grouping_paths() as well.
>
> Thanks for the review!

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 2016/11/04 0:29, Robert Haas wrote:
> Committed.

Thanks!

Tatsuro Yamada
NTT Open Source Software Center