Thread: [PATCH] pg_filedump is broken

Hello.

First patch fixes:

```
pg_filedump.c: In function ‘FormatItem’:
pg_filedump.c:994:18: error: ‘SizeOfIptrData’ undeclared (first use in
                      this function)
   if (numBytes < SizeOfIptrData)
```

After 8023b582 there is no more SizeOfIptrData macro.

Second patch fixes Makefile. On some systems (notably FreeBSD) there is
no `gcc` by default. Using `cc` is a more crossplatform way to compile a
project.

--
Best regards,
Aleksander Alekseev

Re: Aleksander Alekseev 2016-10-12 <20161012111527.GA17916@e733.localdomain>
> Hello.
> 
> First patch fixes:
> 
> ```
> pg_filedump.c: In function ‘FormatItem’:
> pg_filedump.c:994:18: error: ‘SizeOfIptrData’ undeclared (first use in
>                       this function)
>    if (numBytes < SizeOfIptrData)
> ```
> 
> After 8023b582 there is no more SizeOfIptrData macro.

Thanks, pushed to filedump git.

> Second patch fixes Makefile. On some systems (notably FreeBSD) there is
> no `gcc` by default. Using `cc` is a more crossplatform way to compile a
> project.

I think we just shouldn't set CC at all. Pushed along with some more
usage of pg_config.

Christoph

The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            not tested

pg_filedump is a separate git repo, so the commitfest app won't let me mark this as commited by me. I'll mark it as
"returnedwith feedback". Thanks! 

The new status of this patch is: Ready for Committer