Thread: [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server
Hi
When we add new server and enter an invalid port, it validates and display error message, but sometimes it doesn't unset errorModel when a valid value is entered.
Please find attached patch and review.
Thanks,
Surinder Kumar
Attachment
Is there an RM for this? If not, can you create one please? I want to be sure we capture all notable changes in Redmine. Thanks! On Fri, Sep 30, 2016 at 1:53 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote: > Hi > > When we add new server and enter an invalid port, it validates and display > error message, but sometimes it doesn't unset errorModel when a valid value > is entered. > > Please find attached patch and review. > > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server
From
Surinder Kumar
Date:
Dave, I have created RM #1786
On Fri, Sep 30, 2016 at 6:32 PM, Dave Page <dpage@pgadmin.org> wrote:
Is there an RM for this? If not, can you create one please? I want to
be sure we capture all notable changes in Redmine.
Thanks!> --
On Fri, Sep 30, 2016 at 1:53 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> When we add new server and enter an invalid port, it validates and display
> error message, but sometimes it doesn't unset errorModel when a valid value
> is entered.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Thanks. On Fri, Sep 30, 2016 at 2:08 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote: > Dave, I have created RM #1786 > > On Fri, Sep 30, 2016 at 6:32 PM, Dave Page <dpage@pgadmin.org> wrote: >> >> Is there an RM for this? If not, can you create one please? I want to >> be sure we capture all notable changes in Redmine. >> >> Thanks! >> >> On Fri, Sep 30, 2016 at 1:53 PM, Surinder Kumar >> <surinder.kumar@enterprisedb.com> wrote: >> > Hi >> > >> > When we add new server and enter an invalid port, it validates and >> > display >> > error message, but sometimes it doesn't unset errorModel when a valid >> > value >> > is entered. >> > >> > Please find attached patch and review. >> > >> > >> > Thanks, >> > Surinder Kumar >> > >> > >> > -- >> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> > To make changes to your subscription: >> > http://www.postgresql.org/mailpref/pgadmin-hackers >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Thanks, committed. On Fri, Sep 30, 2016 at 2:24 PM, Dave Page <dpage@pgadmin.org> wrote: > Thanks. > > On Fri, Sep 30, 2016 at 2:08 PM, Surinder Kumar > <surinder.kumar@enterprisedb.com> wrote: >> Dave, I have created RM #1786 >> >> On Fri, Sep 30, 2016 at 6:32 PM, Dave Page <dpage@pgadmin.org> wrote: >>> >>> Is there an RM for this? If not, can you create one please? I want to >>> be sure we capture all notable changes in Redmine. >>> >>> Thanks! >>> >>> On Fri, Sep 30, 2016 at 1:53 PM, Surinder Kumar >>> <surinder.kumar@enterprisedb.com> wrote: >>> > Hi >>> > >>> > When we add new server and enter an invalid port, it validates and >>> > display >>> > error message, but sometimes it doesn't unset errorModel when a valid >>> > value >>> > is entered. >>> > >>> > Please find attached patch and review. >>> > >>> > >>> > Thanks, >>> > Surinder Kumar >>> > >>> > >>> > -- >>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> > To make changes to your subscription: >>> > http://www.postgresql.org/mailpref/pgadmin-hackers >>> > >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >> >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company