Thread: [pgAdmin4][Patch]: RM1171 - Fix IE caching issue
Hi
Issue:
IE always caching the response data returned from the server and when same request is made for next time, it doesn't bring new data, instead it use cached data.
Solution:
Set cache to 'no-cache' in response headers while sending from the server side. This prevents browser from caching data every time an http request is made.
Thanks to Harshal & Murtaza for discussing issue and solution.
Please find attached patch and review.
Thanks,
Surinder Kumar
Attachment
This patch has some issue in chrome while loading nodes. I will send updated patch.
On Tue, Sep 20, 2016 at 7:16 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
HiIssue:IE always caching the response data returned from the server and when same request is made for next time, it doesn't bring new data, instead it use cached data.Solution:Set cache to 'no-cache' in response headers while sending from the server side. This prevents browser from caching data every time an http request is made.Thanks to Harshal & Murtaza for discussing issue and solution.Please find attached patch and review.Thanks,Surinder Kumar
Missed method closing parenthesis while calling
Please find updated patch
On Tue, Sep 20, 2016 at 7:25 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
This patch has some issue in chrome while loading nodes. I will send updated patch.On Tue, Sep 20, 2016 at 7:16 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote: HiIssue:IE always caching the response data returned from the server and when same request is made for next time, it doesn't bring new data, instead it use cached data.Solution:Set cache to 'no-cache' in response headers while sending from the server side. This prevents browser from caching data every time an http request is made.Thanks to Harshal & Murtaza for discussing issue and solution.Please find attached patch and review.Thanks,Surinder Kumar
Attachment
Can you rebase please? piranha:web dpage$ git apply ~/Downloads/RM1171_v1.patch error: patch failed: web/pgadmin/utils/ajax.py:29 error: web/pgadmin/utils/ajax.py: patch does not apply On Tue, Sep 20, 2016 at 2:58 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote: > Missed method closing parenthesis while calling > > Please find updated patch > > On Tue, Sep 20, 2016 at 7:25 PM, Surinder Kumar > <surinder.kumar@enterprisedb.com> wrote: >> >> This patch has some issue in chrome while loading nodes. I will send >> updated patch. >> >> On Tue, Sep 20, 2016 at 7:16 PM, Surinder Kumar >> <surinder.kumar@enterprisedb.com> wrote: >>> >>> Hi >>> >>> Issue: >>> IE always caching the response data returned from the server and when >>> same request is made for next time, it doesn't bring new data, instead it >>> use cached data. >>> >>> Solution: >>> Set cache to 'no-cache' in response headers while sending from the server >>> side. This prevents browser from caching data every time an http request is >>> made. >>> >>> Thanks to Harshal & Murtaza for discussing issue and solution. >>> >>> Please find attached patch and review. >>> >>> >>> Thanks, >>> Surinder Kumar >> >> > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Hi
I did git pull and applied the patch without any error. I have attached updated patch.
Please apply this patch and let me know if any issue.
On Wed, Sep 21, 2016 at 5:59 PM, Dave Page <dpage@pgadmin.org> wrote:
Can you rebase please?
piranha:web dpage$ git apply ~/Downloads/RM1171_v1.patch
error: patch failed: web/pgadmin/utils/ajax.py:29
error: web/pgadmin/utils/ajax.py: patch does not apply
On Tue, Sep 20, 2016 at 2:58 PM, Surinder Kumar> --<surinder.kumar@enterprisedb.com> wrote:
> Missed method closing parenthesis while calling
>
> Please find updated patch
>
> On Tue, Sep 20, 2016 at 7:25 PM, Surinder Kumar
> <surinder.kumar@enterprisedb.com> wrote:
>>
>> This patch has some issue in chrome while loading nodes. I will send
>> updated patch.
>>
>> On Tue, Sep 20, 2016 at 7:16 PM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>>>
>>> Hi
>>>
>>> Issue:
>>> IE always caching the response data returned from the server and when
>>> same request is made for next time, it doesn't bring new data, instead it
>>> use cached data.
>>>
>>> Solution:
>>> Set cache to 'no-cache' in response headers while sending from the server
>>> side. This prevents browser from caching data every time an http request is
>>> made.
>>>
>>> Thanks to Harshal & Murtaza for discussing issue and solution.
>>>
>>> Please find attached patch and review.
>>>
>>>
>>> Thanks,
>>> Surinder Kumar
>>
>>
>
>
>
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment
Thanks, applied. On Wed, Sep 21, 2016 at 2:40 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote: > Hi > > I did git pull and applied the patch without any error. I have attached > updated patch. > Please apply this patch and let me know if any issue. > > On Wed, Sep 21, 2016 at 5:59 PM, Dave Page <dpage@pgadmin.org> wrote: >> >> Can you rebase please? >> >> piranha:web dpage$ git apply ~/Downloads/RM1171_v1.patch >> error: patch failed: web/pgadmin/utils/ajax.py:29 >> error: web/pgadmin/utils/ajax.py: patch does not apply >> >> On Tue, Sep 20, 2016 at 2:58 PM, Surinder Kumar >> <surinder.kumar@enterprisedb.com> wrote: >> > Missed method closing parenthesis while calling >> > >> > Please find updated patch >> > >> > On Tue, Sep 20, 2016 at 7:25 PM, Surinder Kumar >> > <surinder.kumar@enterprisedb.com> wrote: >> >> >> >> This patch has some issue in chrome while loading nodes. I will send >> >> updated patch. >> >> >> >> On Tue, Sep 20, 2016 at 7:16 PM, Surinder Kumar >> >> <surinder.kumar@enterprisedb.com> wrote: >> >>> >> >>> Hi >> >>> >> >>> Issue: >> >>> IE always caching the response data returned from the server and when >> >>> same request is made for next time, it doesn't bring new data, instead >> >>> it >> >>> use cached data. >> >>> >> >>> Solution: >> >>> Set cache to 'no-cache' in response headers while sending from the >> >>> server >> >>> side. This prevents browser from caching data every time an http >> >>> request is >> >>> made. >> >>> >> >>> Thanks to Harshal & Murtaza for discussing issue and solution. >> >>> >> >>> Please find attached patch and review. >> >>> >> >>> >> >>> Thanks, >> >>> Surinder Kumar >> >> >> >> >> > >> > >> > >> > -- >> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> > To make changes to your subscription: >> > http://www.postgresql.org/mailpref/pgadmin-hackers >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company