Thread: pgAdmin IV- Testing framework: Enhanced Test Result Summary

pgAdmin IV- Testing framework: Enhanced Test Result Summary

From
Navnath Gadakh
Date:
Hi Dave,
     Please find the patch for the enhanced test result summary for testing framework. The code for this, was completed before drop object's functionality & independent from drop objects work.
Drop objects work will take time, I am working on that for remaining nodes. Meanwhile, we go ahead with enhanced test summary.

To run the test suite follow the commands
1. python regression/runtests.py --pkg browser.server_groups.servers
2. python regression/runtests.py --pkg browser.server_groups.servers.databases 

 
--
Thanks,
Navnath Gadakh
Software Engineer
EnterpriseDB Corporation
Mobile: +91 9975389878 


Attachment

Re: pgAdmin IV- Testing framework: Enhanced Test Result Summary

From
Dave Page
Date:
Hi

On Fri, Sep 16, 2016 at 2:37 PM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
>      Please find the patch for the enhanced test result summary for testing
> framework. The code for this, was completed before drop object's
> functionality & independent from drop objects work.
> Drop objects work will take time, I am working on that for remaining nodes.
> Meanwhile, we go ahead with enhanced test summary.
>
> To run the test suite follow the commands
> 1. python regression/runtests.py --pkg browser.server_groups.servers
> 2. python regression/runtests.py --pkg
> browser.server_groups.servers.databases

I'm seeing some issues with this patch:

- There are updates to config.py and setup.py that shouldn't be there.
- I get this error at the end of a successful test run:

Test Result Summary
============================
Regression - PG 9.4: 25 tests passed, 0 tests failed
============================

Please check output in file:
/Users/dpage/git/pgadmin4/web/regression/regression.log
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
360, in drop_objects
    file_name, sys.exc_traceback.tb_lineno, exception))
Exception: test_utils.py: line:337 'NoneType' object has no attribute
'__getitem__'
Error in sys.exitfunc:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
360, in drop_objects
    file_name, sys.exc_traceback.tb_lineno, exception))
Exception: test_utils.py: line:337 'NoneType' object has no attribute
'__getitem__'

--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


Re: pgAdmin IV- Testing framework: Enhanced Test Result Summary

From
Navnath Gadakh
Date:
Hi Dave,
    Error resolved. Please find the revised patch.

On Fri, Sep 16, 2016 at 9:23 PM, Dave Page <dave.page@enterprisedb.com> wrote:
Hi

On Fri, Sep 16, 2016 at 2:37 PM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
>      Please find the patch for the enhanced test result summary for testing
> framework. The code for this, was completed before drop object's
> functionality & independent from drop objects work.
> Drop objects work will take time, I am working on that for remaining nodes.
> Meanwhile, we go ahead with enhanced test summary.
>
> To run the test suite follow the commands
> 1. python regression/runtests.py --pkg browser.server_groups.servers
> 2. python regression/runtests.py --pkg
> browser.server_groups.servers.databases

I'm seeing some issues with this patch:

- There are updates to config.py and setup.py that shouldn't be there.
- I get this error at the end of a successful test run:

Test Result Summary
============================
Regression - PG 9.4: 25 tests passed, 0 tests failed
============================

Please check output in file:
/Users/dpage/git/pgadmin4/web/regression/regression.log
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
360, in drop_objects
    file_name, sys.exc_traceback.tb_lineno, exception))
Exception: test_utils.py: line:337 'NoneType' object has no attribute
'__getitem__'
Error in sys.exitfunc:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
360, in drop_objects
    file_name, sys.exc_traceback.tb_lineno, exception))
Exception: test_utils.py: line:337 'NoneType' object has no attribute
'__getitem__'


  Thanks. 
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake



--
Regards,
Navnath


Attachment

Re: pgAdmin IV- Testing framework: Enhanced Test Result Summary

From
Dave Page
Date:
Hi

On Mon, Sep 19, 2016 at 8:14 AM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
>     Error resolved. Please find the revised patch.

I still see the error:

Test Result Summary
============================
Regression - PG 9.4: 25 tests passed, 0 tests failed
============================

Please check output in file:
/Users/dpage/git/pgadmin4/web/regression/regression.log
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
360, in drop_objects
    file_name, sys.exc_traceback.tb_lineno, exception))
Exception: test_utils.py: line:337 'NoneType' object has no attribute
'__getitem__'
Error in sys.exitfunc:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
360, in drop_objects
    file_name, sys.exc_traceback.tb_lineno, exception))
Exception: test_utils.py: line:337 'NoneType' object has no attribute
'__getitem__'


--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


Re: pgAdmin IV- Testing framework: Enhanced Test Result Summary

From
Navnath Gadakh
Date:
Hi Dave,
      In the drop objects function scenario for 'NoneType' was not handled. Code is added in the revised patch.

Thanks.

On Mon, Sep 19, 2016 at 2:03 PM, Dave Page <dave.page@enterprisedb.com> wrote:
Hi

On Mon, Sep 19, 2016 at 8:14 AM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
>     Error resolved. Please find the revised patch.

I still see the error:

Test Result Summary
============================
Regression - PG 9.4: 25 tests passed, 0 tests failed
============================

Please check output in file:
/Users/dpage/git/pgadmin4/web/regression/regression.log
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
360, in drop_objects
    file_name, sys.exc_traceback.tb_lineno, exception))
Exception: test_utils.py: line:337 'NoneType' object has no attribute
'__getitem__'
Error in sys.exitfunc:
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
360, in drop_objects
    file_name, sys.exc_traceback.tb_lineno, exception))
Exception: test_utils.py: line:337 'NoneType' object has no attribute
'__getitem__'


--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake



--
Regards,
Navnath


Attachment

Re: pgAdmin IV- Testing framework: Enhanced Test Result Summary

From
Dave Page
Date:
Thanks - applied with minor tweaks to the output formatting.

On Mon, Sep 19, 2016 at 2:03 PM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
>       In the drop objects function scenario for 'NoneType' was not handled.
> Code is added in the revised patch.
>
> Thanks.
>
> On Mon, Sep 19, 2016 at 2:03 PM, Dave Page <dave.page@enterprisedb.com>
> wrote:
>>
>> Hi
>>
>> On Mon, Sep 19, 2016 at 8:14 AM, Navnath Gadakh
>> <navnath.gadakh@enterprisedb.com> wrote:
>> > Hi Dave,
>> >     Error resolved. Please find the revised patch.
>>
>> I still see the error:
>>
>> Test Result Summary
>> ============================
>> Regression - PG 9.4: 25 tests passed, 0 tests failed
>> ============================
>>
>> Please check output in file:
>> /Users/dpage/git/pgadmin4/web/regression/regression.log
>> Error in atexit._run_exitfuncs:
>> Traceback (most recent call last):
>>   File
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
>> line 24, in _run_exitfuncs
>>     func(*targs, **kargs)
>>   File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
>> 360, in drop_objects
>>     file_name, sys.exc_traceback.tb_lineno, exception))
>> Exception: test_utils.py: line:337 'NoneType' object has no attribute
>> '__getitem__'
>> Error in sys.exitfunc:
>> Traceback (most recent call last):
>>   File
>> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py",
>> line 24, in _run_exitfuncs
>>     func(*targs, **kargs)
>>   File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line
>> 360, in drop_objects
>>     file_name, sys.exc_traceback.tb_lineno, exception))
>> Exception: test_utils.py: line:337 'NoneType' object has no attribute
>> '__getitem__'
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>
>
>
>
> --
> Regards,
> Navnath
>
>



--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake