Thread: Wierded error in recursive function; debugging ideas?

Wierded error in recursive function; debugging ideas?

From
Josh Berkus
Date:
Folks,

I'm seeing this bizarre, unreproducable error in my logs:

[2] Wrong datatype for second argument in call to in_array
  SQL: SELECT sf_event_decendants(66645,111)

The problem is that it's proven completely impossible to reproduce this error
at test time; it only seems to happen in production, and then only one out of
about 200 times the function is called (although when the function errors it
does seem to error 3-5 times in a row).

sf_event_descendants is a recursive function which maps out which child events
of the current event are visible to the current user.   It does use arrays.
I did try tinkering with some of the functions internals without apparent
effect.

I also checked for in_array and it's not a visible built-in function.  Is this
maybe a PostgreSQL bug?   Version is 7.4.1

--
-Josh Berkus"A developer of Very Little Brain"Aglio Database SolutionsSan Francisco



Re: Wierded error in recursive function; debugging ideas?

From
Joe Conway
Date:
Josh Berkus wrote:
> I'm seeing this bizarre, unreproducable error in my logs:
> 
> [2] Wrong datatype for second argument in call to in_array
>   SQL: SELECT sf_event_decendants(66645,111)
> I also checked for in_array and it's not a visible built-in function.  Is this 
> maybe a PostgreSQL bug?   Version is 7.4.1
> 

There is no in_array() function in Postgres that I'm aware of -- you 
sure that isn't array_in()? The rest of that error message doesn't seem 
to be there in 7.4 either. Can we see the function?

Joe


Re: Wierded error in recursive function; debugging ideas?

From
Josh Berkus
Date:
Joe,

> There is no in_array() function in Postgres that I'm aware of -- you 
> sure that isn't array_in()?

Yep.  That's a cut-and-paste of the exact log message.

> The rest of that error message doesn't seem 
> to be there in 7.4 either. Can we see the function?

Sure:

CREATE OR REPLACE FUNCTION "sf_event_decendants" (integer,integer)
RETURNS text AS '
DECLARE v_event ALIAS for $1;v_user ALIAS for $2;child_list INT[];sub_child TEXT;child_rec RECORD;p_status INT;contfrom
INT;
BEGIN
child_list := ARRAY [ 0 ];
SELECT status INTO p_status
FROM events WHERE event_id = v_event;
IF p_status < 0 THENp_status = -99;
ELSEp_status = 0;
END IF;
FOR child_rec IN SELECT event_id FROM eventsWHERE parent_id = v_event AND status > p_status LOOPchild_list :=
child_rec.event_id|| child_list;IF v_user <> 0 THEN    IF if_get_lock(v_user, ''events'', child_rec.event_id, NULL) <>
''OK''THEN        RETURN ''LOCKED:  One or more of the child events of the current event are 
 
locked by '' ||            ''another user at this time.  You cannot proceed.'';    END IF;END IF;
END LOOP;
FOR child_rec IN SELECT event_id FROM eventsWHERE (continued_id = v_event or event_id = COALESCE(contfrom, 0)) and
status
 
> p_status LOOPchild_list := child_rec.event_id || child_list;IF v_user <> 0 THEN    IF if_get_lock(v_user, ''events'',
child_rec.event_id,NULL) <> ''OK'' THEN        RETURN ''LOCKED:  One or more of the child events of the current event
are
 
locked by '' ||            ''another user at this time.  You cannot proceed.'';    END IF;END IF;
END LOOP;
IF child_list = ARRAY[0] THENRETURN ''0'';
END IF;
FOR child_rec IN SELECT event_id FROM events            WHERE status > p_status            AND event_id = ANY (
child_list)            LOOPsub_child := sf_event_decendants(child_rec.event_id, v_user);IF sub_child <> ''0'' THEN
child_list:= child_list || string_to_array(sub_child, '','')::INT[];    IF v_user <> 0 THEN        IF
if_get_lock(v_user,''events'', child_rec.event_id, NULL) <> ''OK'' THEN            RETURN ''LOCKED:  One or more of the
childevents of the current event are 
 
locked by '' ||                ''another user at this time.  You cannot proceed.'';        END IF;    END IF;END IF;
END LOOP;
RETURN array_to_string(child_list, '','');
END;' LANGUAGE 'plpgsql';



-- 
-Josh Berkus"A developer of Very Little Brain"Aglio Database SolutionsSan Francisco



Re: Wierded error in recursive function; debugging ideas?

From
Joe Conway
Date:
Josh Berkus wrote:
> [2] Wrong datatype for second argument in call to in_array
>   SQL: SELECT sf_event_decendants(66645,111)
> 

Are you sure this message isn't coming from some PHP middleware, e.g. 
peardb or something. See:
http://us2.php.net/manual/en/function.in-array.php

Joe


Re: Wierded error in recursive function; debugging ideas?

From
Josh Berkus
Date:
Joe,
> Are you sure this message isn't coming from some PHP middleware, e.g. 
> peardb or something. See:
> http://us2.php.net/manual/en/function.in-array.php

Hmmmmm ... possible.  Will check with my PHP guy.

Would explain why I've not been able to track down the error. 

-- 
-Josh Berkus"A developer of Very Little Brain"Aglio Database SolutionsSan Francisco