Thread: reviews not completed and/or additional review needed

We have a number of reviews that have not been completed, and others
that have had basic testing but need code review and/or performance
testing.  Volunteers to tackle these would be appreciated.  If some
patches end up getting reviewed by the original reviewer as well,
that's OK too.  Multiple reviews are good.

Merge Append - assigned to Abhijit Menon-Sen and claimed, but no review posted.

Support for EEEE in to_char() - assigned to Euler Taveira de Oliveira,
but never claimed and no review posted.  Dave Fetter did some initial
testing, still needs code review.

COPY WITH CSV FORCE QUOTE * - Josh Berkus did some initial testing,
still needs code review

multi-threaded pgbench - Greg Smith's name is next to this one, but he
didn't respond to email, so may not be planning to review it.  So this
one needs code review and performance testing.

Thanks,

...Robert

On Wed, Jul 22, 2009 at 9:41 PM, Robert Haas<robertmhaas@gmail.com> wrote:
> multi-threaded pgbench - Greg Smith's name is next to this one, but he
> didn't respond to email, so may not be planning to review it.  So this
> one needs code review and performance testing.

It seems I spoke too soon on this one; Greg Smith just posted a
detailed review.  However, he did mention that he does not have a lot
of experience with the Windows side of the house, so if anyone has
Windows expertise, help here would be greatly appreciated.  I don't
think anyone who signed up to be a round-robin reviewer mentioned that
they had experience in this area, so if you do you're a hot commodity.

Thanks to everyone for all the reviewing done thus far - I think this
has really been going very smoothly and that we are making good
progress.  Let's keep at it...

...Robert

On Wed, 2009-07-22 at 22:48 -0400, Robert Haas wrote:
> It seems I spoke too soon on this one; Greg Smith just posted a
> detailed review.  However, he did mention that he does not have a lot
> of experience with the Windows side of the house, so if anyone has
> Windows expertise, help here would be greatly appreciated.  I don't
> think anyone who signed up to be a round-robin reviewer mentioned that
> they had experience in this area, so if you do you're a hot commodity.

Just got a Windows build environment going here.  Haven't looked inside
the patch but I could probably at least get some performance results
from that early next week.

- Josh Williams

On Thu, Jul 23, 2009 at 5:50 PM, Josh Williams<joshwilliams@ij.net> wrote:
> On Wed, 2009-07-22 at 22:48 -0400, Robert Haas wrote:
>> It seems I spoke too soon on this one; Greg Smith just posted a
>> detailed review.  However, he did mention that he does not have a lot
>> of experience with the Windows side of the house, so if anyone has
>> Windows expertise, help here would be greatly appreciated.  I don't
>> think anyone who signed up to be a round-robin reviewer mentioned that
>> they had experience in this area, so if you do you're a hot commodity.
>
> Just got a Windows build environment going here.  Haven't looked inside
> the patch but I could probably at least get some performance results
> from that early next week.

That would be great.  Please add your name as a reviewer on
commitfest.postgresql.org.

...Robert