Thread: ARM fixes (fwd)
------- Forwarded Message
Date: Wed, 17 Nov 1999 23:54:15 -0800
From: "David N. Welton" <davidw@prosa.it>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: Bug#50518: ARM fixes
Package: postgresql
Version: 6.5.2-3
Severity: wishlist
src/template/linux_arm:
AROPT:crs
CFLAGS:-O0
SHARED_LIB:-fpic
ALL:
SRCH_INC:
SRCH_LIB:
USE_LOCALE:no
DLSUFFIX:.so
YFLAGS:-d
YACC:bison -y
In src/include/storage/s_lock.h,
#if defined(__arm32__)
would be better as:
#if defined(__arm__)
...
------- End of Forwarded Message
Apparently this is necessary for PostgreSQL to compile on ARM.
--
Vote against SPAM: http://www.politik-digital.de/spam/
========================================
Oliver Elphick Oliver.Elphick@lfix.co.uk
Isle of Wight http://www.lfix.co.uk/oliver
PGP key from public servers; key ID 32B8FAA1
========================================
"A Song for the sabbath day. It is a good thing to
give thanks unto the LORD, and to sing praises unto
thy name, O most High." Psalms 92:1
Oliver Elphick wrote: > Apparently this is necessary for PostgreSQL to compile on ARM. I found patches similar to these for getting the RPM's built on ARM -- specifically, for RPM installs on the Corel/Rebel.Com NetWinder. The patchset was applied to (I'm assuming) both CVS branches by Bruce. This was shortly after the release of 6.5.3. I can send you the whole patchset (<2K) or you can do a CVS checkout of REL6_5_PATCHES. The 6.5.3-1 source RPM builds as-is on ARMlinux for the NetWinder. -- Lamar Owen WGCR Internet Radio 1 Peter 4:11
Applied. WIll appear in 7.0. Is there a reason optimization was turned off. I have not applied that fix. > > ------- Forwarded Message > > Date: Wed, 17 Nov 1999 23:54:15 -0800 > From: "David N. Welton" <davidw@prosa.it> > To: Debian Bug Tracking System <submit@bugs.debian.org> > Subject: Bug#50518: ARM fixes > > Package: postgresql > Version: 6.5.2-3 > Severity: wishlist > > src/template/linux_arm: > AROPT:crs > CFLAGS:-O0 > SHARED_LIB:-fpic > ALL: > SRCH_INC: > SRCH_LIB: > USE_LOCALE:no > DLSUFFIX:.so > YFLAGS:-d > YACC:bison -y > > In src/include/storage/s_lock.h, > > #if defined(__arm32__) > > would be better as: > > #if defined(__arm__) > > > ... > ------- End of Forwarded Message > > Apparently this is necessary for PostgreSQL to compile on ARM. > > -- > Vote against SPAM: http://www.politik-digital.de/spam/ > ======================================== > Oliver Elphick Oliver.Elphick@lfix.co.uk > Isle of Wight http://www.lfix.co.uk/oliver > PGP key from public servers; key ID 32B8FAA1 > ======================================== > "A Song for the sabbath day. It is a good thing to > give thanks unto the LORD, and to sing praises unto > thy name, O most High." Psalms 92:1 > > > > ************ > -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
I don't see the same __arm32_ defines I have in 7.0 tree. > Oliver Elphick wrote: > > Apparently this is necessary for PostgreSQL to compile on ARM. > > I found patches similar to these for getting the RPM's built on ARM -- > specifically, for RPM installs on the Corel/Rebel.Com NetWinder. The > patchset was applied to (I'm assuming) both CVS branches by Bruce. This > was shortly after the release of 6.5.3. I can send you the whole > patchset (<2K) or you can do a CVS checkout of REL6_5_PATCHES. > > The 6.5.3-1 source RPM builds as-is on ARMlinux for the NetWinder. > > -- > Lamar Owen > WGCR Internet Radio > 1 Peter 4:11 > > ************ > > -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Bruce Momjian wrote: > > I don't see the same __arm32_ defines I have in 7.0 tree. You don't see them in REL6_5_PATCHES, you mean? So, you only applied them to CURRENT? -- Lamar Owen WGCR Internet Radio 1 Peter 4:11
> Bruce Momjian wrote: > > > > I don't see the same __arm32_ defines I have in 7.0 tree. > > You don't see them in REL6_5_PATCHES, you mean? So, you only applied > them to CURRENT? Yes, only current. I suspect the original patch was too risky for the stable tree. -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Bruce Momjian wrote: > > > Bruce Momjian wrote: > > > > > > I don't see the same __arm32_ defines I have in 7.0 tree. > > > > You don't see them in REL6_5_PATCHES, you mean? So, you only applied > > them to CURRENT? > > Yes, only current. I suspect the original patch was too risky for the > stable tree. Ok; I am shipping those patches with the 6.5.3 RPM's. There are not major changes made by them -- just minor defines, the linux_arm template, etc. Do you want to re-review them for inclusion in REL6_5_PATCHES, or just wait?? They're only 2K. -- Lamar Owen WGCR Internet Radio 1 Peter 4:11
> Bruce Momjian wrote: > > > > > Bruce Momjian wrote: > > > > > > > > I don't see the same __arm32_ defines I have in 7.0 tree. > > > > > > You don't see them in REL6_5_PATCHES, you mean? So, you only applied > > > them to CURRENT? > > > > Yes, only current. I suspect the original patch was too risky for the > > stable tree. > > Ok; I am shipping those patches with the 6.5.3 RPM's. There are not > major changes made by them -- just minor defines, the linux_arm > template, etc. Do you want to re-review them for inclusion in > REL6_5_PATCHES, or just wait?? They're only 2K. We never seem to understand all the affects patches have, especially when they affect s_lock.c or s_lock.h. Don't�think they should appear in 6.5.*. We can make a separate patch for ARM and put it in the patches directory like we did for Alpha. -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
> Bruce Momjian wrote: > > > > I don't see the same __arm32_ defines I have in 7.0 tree. > > You don't see them in REL6_5_PATCHES, you mean? So, you only applied > them to CURRENT? Yes, only current. -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Bruce Momjian wrote:
>
>Applied. WIll appear in 7.0.
>
>
>Is there a reason optimization was turned off. I have not applied that
>fix.
The Debian source release did not contain the linux-arm template at all;
apparently that is after 6.5.3?
I think David copied and modified another architecture. It did confuse
me horribly!
--
Vote against SPAM: http://www.politik-digital.de/spam/
========================================
Oliver Elphick Oliver.Elphick@lfix.co.uk
Isle of Wight http://www.lfix.co.uk/oliver
PGP key from public servers; key ID 32B8FAA1
========================================
"A Song for the sabbath day. It is a good thing to
give thanks unto the LORD, and to sing praises unto
thy name, O most High." Psalms 92:1
Bruce Momjian wrote: > > Ok; I am shipping those patches with the 6.5.3 RPM's. There are not > > major changes made by them -- just minor defines, the linux_arm > > template, etc. Do you want to re-review them for inclusion in > > REL6_5_PATCHES, or just wait?? They're only 2K. > > We never seem to understand all the affects patches have, especially > when they affect s_lock.c or s_lock.h. Don't think they should appear > in 6.5.*. We can make a separate patch for ARM and put it in the > patches directory like we did for Alpha. Fair enough. I'm attaching the patchset as I packaged it for inclusion in a patches directory. -- Lamar Owen WGCR Internet Radio 1 Peter 4:11