Thread: pgfincore94 fails check-files on EL-7

pgfincore94 fails check-files on EL-7

From
Bernd Helmle
Date:
Today i saw this when building the pgfincore94 RPM package for EL-7 (sorry
for the german error message):

Prüfe auf nicht gepackte Datei(en): /usr/lib/rpm/check-files
/home/credativ/rpm/BUILDROOT/pgfincore94-1.1.2-1.rhel7.ppc64
Fehler: Installierte (aber nicht gepackte) Datei(en) gefunden:
   /usr/pgsql-9.4/doc/pgfincore/README.rst


Fehler beim Bauen des RPM:
    Installierte (aber nicht gepackte) Datei(en) gefunden:
   /usr/pgsql-9.4/doc/pgfincore/README.rst
make: *** [nopreprpm] Fehler 1

It fails the check-files check, since pgfincore installs its README.rst
file in %{buildroot}/usr/pgsql-9.4/doc/pgfincore.

The following patch fixes that, however, i'm not sure why we install the
README.rst explicitly in /usr/pgsql-9.4 given that we have a %doc directive
already in the SPEC file?

--
Thanks

    Bernd

Attachment

Re: pgfincore94 fails check-files on EL-7

From
Devrim GÜNDÜZ
Date:
Hi Bernd,

Can you please update to the 9.4.6 before building this package?

I bite the bullet, and specified --docdir and --htmldir parameters also to the
9.2, 9.3 and 9.4 PostgreSQL RPMs in the latest updates, and built all the 3rd
party stuff with new layout. Otherwise, we would have to maintain 3rd party
stuff in a more expensive way. 

Maybe I should have added dependency to => 9.4.6 in all spec files :-(

Regards, Devrim

On Fri, 2016-03-11 at 12:59 +0100, Bernd Helmle wrote:
> Today i saw this when building the pgfincore94 RPM package for EL-7 (sorry
> for the german error message):
>
> Prüfe auf nicht gepackte Datei(en): /usr/lib/rpm/check-files
> /home/credativ/rpm/BUILDROOT/pgfincore94-1.1.2-1.rhel7.ppc64
> Fehler: Installierte (aber nicht gepackte) Datei(en) gefunden:
>    /usr/pgsql-9.4/doc/pgfincore/README.rst
>
>
> Fehler beim Bauen des RPM:
>     Installierte (aber nicht gepackte) Datei(en) gefunden:
>    /usr/pgsql-9.4/doc/pgfincore/README.rst
> make: *** [nopreprpm] Fehler 1
>
> It fails the check-files check, since pgfincore installs its README.rst
> file in %{buildroot}/usr/pgsql-9.4/doc/pgfincore.
>
> The following patch fixes that, however, i'm not sure why we install the
> README.rst explicitly in /usr/pgsql-9.4 given that we have a %doc directive
> already in the SPEC file? 
>

--
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR



Attachment

Re: pgfincore94 fails check-files on EL-7

From
Bernd Helmle
Date:

--On 15. März 2016 14:02:36 +0200 Devrim GÜNDÜZ <devrim@gunduz.org>
wrote:

> Hi Bernd,
>
> Can you please update to the 9.4.6 before building this package?

Hmm looks like the machine is already updated to PostgreSQL 9.4.6 (in fact
i believed first this is a bug in the jenkins build scripts, but they do it
all in the right order).

> Otherwise, we would have to maintain 3rd party
> stuff in a more expensive way. 

Makes sense.

--
Thanks

    Bernd