Thread: volunteer/peer review request

I trust and value the opinions of the members of this list.  Please give
me some constructive criticism on the following code:

http://webdevel.urban.csuohio.edu/lcua_pub/reveal_pub_retrieve.php

Sorry, no control over the colors, if you want plain vanilla:

http://webdevel.urban.csuohio.edu/lcua_pub/pub_retrieve.inc


I have placed comments and cleaned up to the line:

elseif (array_search('submit', $_GET) == "keyword")


Please let me know if this code:

    1) makes sense
    2) is readable
    3) is robust
    4) is flexible
    5) and anything else you want to tell me (well, anything helpful and
constructive).

I am a sole PHP/postgresql programmer in a college full of people who want to
do projects that would involve this as a model.

This is by no means a finished product, it is simply a beginning tool to
get us all started and acclimated here to internet interfaces to
database backends.

I'm comfortable with PHP, but am no professional.  My learning tool is
the documentation that came with both PostgreSQL and PHP, as well as a
few Zend tutorials.

Thank you,
--
--
Chadwick Rolfs

Usally on a fatal error (like no DB connection) in place of
if ($conn)
{
    // Stuff
}
else
{
    // Error
}

I use

if (!$conn) { $err = "No DB Conn"; close_page($err) }

The "close_page($err);" is a call to a function I wote that will dump the
error string (or what ever paramter) and then finish the HTML for me.

/B





----- Original Message -----
From: <cmr@shell.gis.net>
To: <pgsql-php@postgresql.org>
Sent: Saturday, March 22, 2003 14:09
Subject: [PHP] volunteer/peer review request


> I trust and value the opinions of the members of this list.  Please give
> me some constructive criticism on the following code:
>
> http://webdevel.urban.csuohio.edu/lcua_pub/reveal_pub_retrieve.php
>
> Sorry, no control over the colors, if you want plain vanilla:
>
> http://webdevel.urban.csuohio.edu/lcua_pub/pub_retrieve.inc
>
>
> I have placed comments and cleaned up to the line:
>
> elseif (array_search('submit', $_GET) == "keyword")
>
>
> Please let me know if this code:
>
> 1) makes sense
> 2) is readable
> 3) is robust
> 4) is flexible
> 5) and anything else you want to tell me (well, anything helpful and
> constructive).
>
> I am a sole PHP/postgresql programmer in a college full of people who want
to
> do projects that would involve this as a model.
>
> This is by no means a finished product, it is simply a beginning tool to
> get us all started and acclimated here to internet interfaces to
> database backends.
>
> I'm comfortable with PHP, but am no professional.  My learning tool is
> the documentation that came with both PostgreSQL and PHP, as well as a
> few Zend tutorials.
>
> Thank you,
> --
> --
> Chadwick Rolfs
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faqs/FAQ.html