Thread: compiler warning fix

compiler warning fix

From
Zdenek Kotala
Date:
Sun studio reports following warnings during
src/interfaces/ecpg/ecpglib/prepare.c compilation:

"prepare.c", line 34: warning: storage class after type is obsolescent
"prepare.c", line 35: warning: storage class after type is obsolescent


Attached patch fixes a problem.


        Zdenek
Index: src/interfaces/ecpg/ecpglib/prepare.c
===================================================================
RCS file: /zfs_data/cvs_pgsql/cvsroot/pgsql/src/interfaces/ecpg/ecpglib/prepare.c,v
retrieving revision 1.22
diff -c -r1.22 prepare.c
*** src/interfaces/ecpg/ecpglib/prepare.c    3 Oct 2007 11:11:12 -0000    1.22
--- src/interfaces/ecpg/ecpglib/prepare.c    5 Nov 2007 20:35:41 -0000
***************
*** 31,38 ****
  } stmtCacheEntry;

  static int             nextStmtID               = 1;
! const static int       stmtCacheNBuckets        = 2039;     /* # buckets - a prime # */
! const static int       stmtCacheEntPerBucket    = 8;        /* # entries/bucket     */
  static stmtCacheEntry  stmtCacheEntries[16384] = {{0,{0},0,0,0}};

  static struct prepared_statement *find_prepared_statement(const char *name,
--- 31,38 ----
  } stmtCacheEntry;

  static int             nextStmtID               = 1;
! static const int       stmtCacheNBuckets        = 2039;     /* # buckets - a prime # */
! static const int       stmtCacheEntPerBucket    = 8;        /* # entries/bucket     */
  static stmtCacheEntry  stmtCacheEntries[16384] = {{0,{0},0,0,0}};

  static struct prepared_statement *find_prepared_statement(const char *name,

Re: compiler warning fix

From
Tom Lane
Date:
Zdenek Kotala <Zdenek.Kotala@Sun.COM> writes:
> Sun studio reports following warnings during
> src/interfaces/ecpg/ecpglib/prepare.c compilation:
> "prepare.c", line 34: warning: storage class after type is obsolescent
> "prepare.c", line 35: warning: storage class after type is obsolescent

Yeah, it's right: the C spec deprecates that.  Patch applied, thanks.

            regards, tom lane