Thread: Adjustment of test_fsync.c

Adjustment of test_fsync.c

From
"Hiroshi Saito"
Date:
Hi Bruce-san.

It is somewhat out of order at MinGW (gcc).
(CVS-HEAD)

make[1]: Leaving directory `/home/hiroshi/postgresql-8.3b1-2007-10-18/src/port'
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-afterstatement -Wendif-labels
 -fno-strict-aliasing -I../../../src/interfaces/libpq -../../../src/include -I./src/include/port/win32
 -DEXEC_BACKEND  "-I../../../srcinclude/port/win32"  -c -o test_fsync.o test_fsync.c
test_fsync.c:75:39: macro "open" requires 3 arguments, but only 2 given
test_fsync.c: In function `main':
test_fsync.c:75: warning: assignment makes integer from pointer without a cast
test_fsync.c:93:39: macro "open" requires 3 arguments, but only 2 given
test_fsync.c:93: warning: assignment makes integer from pointer without a cast
test_fsync.c:100:39: macro "open" requires 3 arguments, but only 2 given
test_fsync.c:100: warning: assignment makes integer from pointer without a cast
test_fsync.c:114:39: macro "open" requires 3 arguments, but only 2 given
test_fsync.c:114: warning: assignment makes integer from pointer without a cast
test_fsync.c:120:39: macro "open" requires 3 arguments, but only 2 given
test_fsync.c:120: warning: assignment makes integer from pointer without a cast
test_fsync.c:172:48: macro "open" requires 3 arguments, but only 2 given
test_fsync.c:172: warning: assignment makes integer from pointer without a cast
test_fsync.c:222:38: macro "open" requires 3 arguments, but only 2 given
test_fsync.c:222: warning: assignment makes integer from pointer without a cast
test_fsync.c:242:48: macro "open" requires 3 arguments, but only 2 given
test_fsync.c:242: warning: assignment makes integer from pointer without a cast
test_fsync.c:303:38: macro "open" requires 3 arguments, but only 2 given
test_fsync.c:303: warning: assignment makes integer from pointer without a cast
make: *** [test_fsync.o] Error 1
/END

Please take this into consideration.
Thanks.

Regards,
Hiroshi Saito

Attachment

Re: Adjustment of test_fsync.cf

From
Bruce Momjian
Date:
Patch applied.  Yes, open should take three arguments. Thanks.

---------------------------------------------------------------------------


Hiroshi Saito wrote:
> Hi Bruce-san.
>
> It is somewhat out of order at MinGW (gcc).
> (CVS-HEAD)
>
> make[1]: Leaving directory `/home/hiroshi/postgresql-8.3b1-2007-10-18/src/port'
> gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-afterstatement -Wendif-labels
>  -fno-strict-aliasing -I../../../src/interfaces/libpq -../../../src/include -I./src/include/port/win32
>  -DEXEC_BACKEND  "-I../../../srcinclude/port/win32"  -c -o test_fsync.o test_fsync.c
> test_fsync.c:75:39: macro "open" requires 3 arguments, but only 2 given
> test_fsync.c: In function `main':
> test_fsync.c:75: warning: assignment makes integer from pointer without a cast
> test_fsync.c:93:39: macro "open" requires 3 arguments, but only 2 given
> test_fsync.c:93: warning: assignment makes integer from pointer without a cast
> test_fsync.c:100:39: macro "open" requires 3 arguments, but only 2 given
> test_fsync.c:100: warning: assignment makes integer from pointer without a cast
> test_fsync.c:114:39: macro "open" requires 3 arguments, but only 2 given
> test_fsync.c:114: warning: assignment makes integer from pointer without a cast
> test_fsync.c:120:39: macro "open" requires 3 arguments, but only 2 given
> test_fsync.c:120: warning: assignment makes integer from pointer without a cast
> test_fsync.c:172:48: macro "open" requires 3 arguments, but only 2 given
> test_fsync.c:172: warning: assignment makes integer from pointer without a cast
> test_fsync.c:222:38: macro "open" requires 3 arguments, but only 2 given
> test_fsync.c:222: warning: assignment makes integer from pointer without a cast
> test_fsync.c:242:48: macro "open" requires 3 arguments, but only 2 given
> test_fsync.c:242: warning: assignment makes integer from pointer without a cast
> test_fsync.c:303:38: macro "open" requires 3 arguments, but only 2 given
> test_fsync.c:303: warning: assignment makes integer from pointer without a cast
> make: *** [test_fsync.o] Error 1
> /END
>
> Please take this into consideration.
> Thanks.
>
> Regards,
> Hiroshi Saito

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +