Postgres Pro
Downloads
Home   >   mailing lists

Thread: txid cleanup

txid cleanup

From
"Marko Kreen"
Date:
Per Tom comments, attached patch does following:

- Binary I/O support
- Use ActiveSnapshot instead of SerializableSnapshot
- Clarify function purposes
- remove dev targets from Makefile


There should not be any code depending on SerializableSnapshot,
if there is thats a bug that needs fixing.  Fix is easy - use
SERIALIZABLE transaction isolation level.

Also - either Tom or Jan has changed the code to allow
xmin == xmax.  Is such case really valid?  In _recv
code I followed the style, but I was just wondering.

--
marko
Attachment

Re: txid cleanup

From
Tom Lane
Date:
"Marko Kreen" <markokr@gmail.com> writes:
> Also - either Tom or Jan has changed the code to allow
> xmin == xmax.  Is such case really valid?

Yes, at least in CVS HEAD.

            regards, tom lane

Re: txid cleanup

From
Tom Lane
Date:
"Marko Kreen" <markokr@gmail.com> writes:
> Per Tom comments, attached patch does following:
> - Binary I/O support
> - Use ActiveSnapshot instead of SerializableSnapshot
> - Clarify function purposes
> - remove dev targets from Makefile

Applied with some further editorialization.

            regards, tom lane

Re: txid cleanup

From
"Marko Kreen"
Date:
On 10/11/07, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> "Marko Kreen" <markokr@gmail.com> writes:
> > Also - either Tom or Jan has changed the code to allow
> > xmin == xmax.  Is such case really valid?
>
> Yes, at least in CVS HEAD.

Aha, I had missed that.

Thanks for confirmation.

--
marko