TransactionId*Is*InProgress is misspelled in a couple of comments in
twophase.c..
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
Index: src/backend/access/transam/twophase.c
===================================================================
RCS file: /home/hlinnaka/pgcvsrepository/pgsql/src/backend/access/transam/twophase.c,v
retrieving revision 1.35
diff -c -r1.35 twophase.c
*** src/backend/access/transam/twophase.c 8 Sep 2007 20:31:14 -0000 1.35
--- src/backend/access/transam/twophase.c 21 Sep 2007 15:25:37 -0000
***************
*** 353,359 ****
LWLockRelease(TwoPhaseStateLock);
/*
! * Put it into the global ProcArray so TransactionIdInProgress considers
* the XID as still running.
*/
ProcArrayAdd(&gxact->proc);
--- 353,359 ----
LWLockRelease(TwoPhaseStateLock);
/*
! * Put it into the global ProcArray so TransactionIdIsInProgress considers
* the XID as still running.
*/
ProcArrayAdd(&gxact->proc);
***************
*** 979,985 ****
* NB: a side effect of this is to make a dummy ProcArray entry for the
* prepared XID. This must happen before we clear the XID from MyProc,
* else there is a window where the XID is not running according to
! * TransactionIdInProgress, and onlookers would be entitled to assume the
* xact crashed. Instead we have a window where the same XID appears
* twice in ProcArray, which is OK.
*/
--- 979,985 ----
* NB: a side effect of this is to make a dummy ProcArray entry for the
* prepared XID. This must happen before we clear the XID from MyProc,
* else there is a window where the XID is not running according to
! * TransactionIdIsInProgress, and onlookers would be entitled to assume the
* xact crashed. Instead we have a window where the same XID appears
* twice in ProcArray, which is OK.
*/