Thread: Patch needed fot dt.h

Patch needed fot dt.h

From
Guillaume Lelarge
Date:
Hi all,

With latest modification on src/interfaces/ecpg/pgtypeslib/dt_common.c,
DTK_ISODOW is not defined. The patch attached needs to be applied on 8.1
and 8.2 branches to compile successfully.

Regards.


--
Guillaume.
<!-- http://abs.traduc.org/
      http://lfs.traduc.org/
      http://docs.postgresqlfr.org/ -->
? src/interfaces/ecpg/compatlib/libecpg_compat.so.2.2
? src/interfaces/ecpg/ecpglib/libecpg.so.5.2
? src/interfaces/ecpg/include/ecpg_config.h
? src/interfaces/ecpg/pgtypeslib/libpgtypes.so.2.2
? src/interfaces/ecpg/preproc/ecpg
? src/interfaces/ecpg/test/pg_regress
? src/interfaces/ecpg/test/compat_informix/charfuncs
? src/interfaces/ecpg/test/compat_informix/charfuncs.c
? src/interfaces/ecpg/test/compat_informix/dec_test
? src/interfaces/ecpg/test/compat_informix/dec_test.c
? src/interfaces/ecpg/test/compat_informix/rfmtdate
? src/interfaces/ecpg/test/compat_informix/rfmtdate.c
? src/interfaces/ecpg/test/compat_informix/rfmtlong
? src/interfaces/ecpg/test/compat_informix/rfmtlong.c
? src/interfaces/ecpg/test/compat_informix/rnull
? src/interfaces/ecpg/test/compat_informix/rnull.c
? src/interfaces/ecpg/test/compat_informix/test_informix
? src/interfaces/ecpg/test/compat_informix/test_informix.c
? src/interfaces/ecpg/test/compat_informix/test_informix2
? src/interfaces/ecpg/test/compat_informix/test_informix2.c
? src/interfaces/ecpg/test/connect/test1
? src/interfaces/ecpg/test/connect/test1.c
? src/interfaces/ecpg/test/connect/test1.pgc
? src/interfaces/ecpg/test/connect/test2
? src/interfaces/ecpg/test/connect/test2.c
? src/interfaces/ecpg/test/connect/test3
? src/interfaces/ecpg/test/connect/test3.c
? src/interfaces/ecpg/test/connect/test4
? src/interfaces/ecpg/test/connect/test4.c
? src/interfaces/ecpg/test/connect/test5
? src/interfaces/ecpg/test/connect/test5.c
? src/interfaces/ecpg/test/pgtypeslib/dt_test
? src/interfaces/ecpg/test/pgtypeslib/dt_test.c
? src/interfaces/ecpg/test/pgtypeslib/dt_test2
? src/interfaces/ecpg/test/pgtypeslib/dt_test2.c
? src/interfaces/ecpg/test/pgtypeslib/num_test
? src/interfaces/ecpg/test/pgtypeslib/num_test.c
? src/interfaces/ecpg/test/pgtypeslib/num_test2
? src/interfaces/ecpg/test/pgtypeslib/num_test2.c
? src/interfaces/ecpg/test/preproc/comment
? src/interfaces/ecpg/test/preproc/comment.c
? src/interfaces/ecpg/test/preproc/define
? src/interfaces/ecpg/test/preproc/define.c
? src/interfaces/ecpg/test/preproc/init
? src/interfaces/ecpg/test/preproc/init.c
? src/interfaces/ecpg/test/preproc/type
? src/interfaces/ecpg/test/preproc/type.c
? src/interfaces/ecpg/test/preproc/variable
? src/interfaces/ecpg/test/preproc/variable.c
? src/interfaces/ecpg/test/preproc/whenever
? src/interfaces/ecpg/test/preproc/whenever.c
? src/interfaces/ecpg/test/sql/array
? src/interfaces/ecpg/test/sql/array.c
? src/interfaces/ecpg/test/sql/binary
? src/interfaces/ecpg/test/sql/binary.c
? src/interfaces/ecpg/test/sql/code100
? src/interfaces/ecpg/test/sql/code100.c
? src/interfaces/ecpg/test/sql/copystdout
? src/interfaces/ecpg/test/sql/copystdout.c
? src/interfaces/ecpg/test/sql/define
? src/interfaces/ecpg/test/sql/define.c
? src/interfaces/ecpg/test/sql/desc
? src/interfaces/ecpg/test/sql/desc.c
? src/interfaces/ecpg/test/sql/dynalloc
? src/interfaces/ecpg/test/sql/dynalloc.c
? src/interfaces/ecpg/test/sql/dynalloc2
? src/interfaces/ecpg/test/sql/dynalloc2.c
? src/interfaces/ecpg/test/sql/dyntest
? src/interfaces/ecpg/test/sql/dyntest.c
? src/interfaces/ecpg/test/sql/execute
? src/interfaces/ecpg/test/sql/execute.c
? src/interfaces/ecpg/test/sql/fetch
? src/interfaces/ecpg/test/sql/fetch.c
? src/interfaces/ecpg/test/sql/func
? src/interfaces/ecpg/test/sql/func.c
? src/interfaces/ecpg/test/sql/indicators
? src/interfaces/ecpg/test/sql/indicators.c
? src/interfaces/ecpg/test/sql/quote
? src/interfaces/ecpg/test/sql/quote.c
? src/interfaces/ecpg/test/sql/show
? src/interfaces/ecpg/test/sql/show.c
? src/interfaces/ecpg/test/sql/update
? src/interfaces/ecpg/test/sql/update.c
? src/interfaces/ecpg/test/thread/thread
? src/interfaces/ecpg/test/thread/thread.c
? src/interfaces/ecpg/test/thread/thread_implicit
? src/interfaces/ecpg/test/thread/thread_implicit.c
Index: src/interfaces/ecpg/pgtypeslib/dt.h
===================================================================
RCS file: /projects/cvsroot/pgsql/src/interfaces/ecpg/pgtypeslib/dt.h,v
retrieving revision 1.34
diff -r1.34 dt.h
159a160
> #define DTK_ISODOW          37

Re: Patch needed fot dt.h

From
Tom Lane
Date:
Guillaume Lelarge <guillaume@lelarge.info> writes:
> With latest modification on src/interfaces/ecpg/pgtypeslib/dt_common.c,
> DTK_ISODOW is not defined. The patch attached needs to be applied on 8.1
> and 8.2 branches to compile successfully.

I'm wondering why the back-branch patches added a dependency on
DTK_ISODOW in the first place.  That looks more like a copy&paste
error than something intentional.  Michael?

            regards, tom lane

Re: Patch needed fot dt.h

From
Michael Meskes
Date:
On Mon, May 21, 2007 at 10:17:30AM -0400, Tom Lane wrote:
> I'm wondering why the back-branch patches added a dependency on
> DTK_ISODOW in the first place.  That looks more like a copy&paste
> error than something intentional.  Michael?

It is, somehow it slipped through. Just removed it.

Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes@jabber.org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!