Thread: Patch: Allocation of "kind" codes for spatial type.

Tom,

Attached is the modified pg_statistic.h file for this patch. As you
mentioned 200 - 299 is reserved for ESRI st_geometry type. Out of these
values I am using code 200 for st_geometry.

Related threads for this patch:
http://archives.postgresql.org/pgsql-hackers/2007-05/msg00043.php
http://archives.postgresql.org/pgsql-general/2007-04/msg01075.php


Thanks.

Ale.

-----Original Message-----
From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
Sent: Friday, May 04, 2007 10:18 AM
To: Paul Ramsey
Cc: Ale Raza; pgsql-hackers@postgresql.org; John Baleja; PostGIS
Development Discussion
Subject: Re: [HACKERS] Where to find kind code for STATISTIC_KIND
GEOMETRY?

Paul Ramsey <pramsey@refractions.net> writes:
> Just take 150-199, and submit a patch to HACKERS to updates the
comment
> in pg_statistic appropriately. I am sure the it will be some time
before
> we invent another 49 kinds of selectivity statistic.

I've been on the wrong wavelength in this whole thread --- I thought the
OP wanted to know about some existing "kind" value used by PostGIS.  If
he's asking to be allocated some new "kind" values for code he intends
to write, I have no problem with giving him 200-299 ... it's not like
we seem to be in any danger of running out.  But please do submit a
patch in the style of the existing pg_statistic.h comments, showing who
controls those numbers and where they will be documented.

            regards, tom lane

Ale Raza <araza@esri.com> writes:
> Attached is the modified pg_statistic.h file for this patch. As you
> mentioned 200 - 299 is reserved for ESRI st_geometry type. Out of these
> values I am using code 200 for st_geometry.

Done.

For future reference, what people normally mean by a "patch" is
"diff -c" output.  Sending the whole modified file is not convenient
because it can't be dropped-in if there have been any changes since the
version you worked from (as indeed there have been, in this case).

            regards, tom lane

Ok, Thanks, Which release it will be in, PostgreSQL 8.2.5?

Ale.


-----Original Message-----
From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
Sent: Tuesday, May 08, 2007 12:16 PM
To: Ale Raza
Cc: pgsql-patches@postgresql.org; pgsql-hackers@postgresql.org; Paul
Ramsey; John Baleja
Subject: Re: [HACKERS] Patch: Allocation of "kind" codes for spatial
type.

Ale Raza <araza@esri.com> writes:
> Attached is the modified pg_statistic.h file for this patch. As you
> mentioned 200 - 299 is reserved for ESRI st_geometry type. Out of
these
> values I am using code 200 for st_geometry.

Done.

For future reference, what people normally mean by a "patch" is
"diff -c" output.  Sending the whole modified file is not convenient
because it can't be dropped-in if there have been any changes since the
version you worked from (as indeed there have been, in this case).

            regards, tom lane

Ale Raza wrote:
> Ok, Thanks, Which release it will be in, PostgreSQL 8.2.5?

8.3, but you can actually use the numbers in whatever release you
please as it is unlikely that they would have been used by anyone else
(much less somebody with which you would be sharing a database).

--
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support