Thread: this patch correct upper and lower case for translated month's and day's names
this patch correct upper and lower case for translated month's and day's names
From
"Pavel Stehule"
Date:
Hello, this patch correct bug in to_char function with incorrect uppercased month's or day's name. Regards Pavel Stehule _________________________________________________________________ Najdete si svou lasku a nove pratele na Match.com. http://www.msn.cz/
Attachment
Re: this patch correct upper and lower case for translated month's and day's names
From
Tom Lane
Date:
"Pavel Stehule" <pavel.stehule@hotmail.com> writes:
> this patch correct bug in to_char function with incorrect uppercased month's
> or day's name.
I still think this coding is unsafe in the case where the modified
string is longer than the original. Also, could we please not duplicate
such a large chunk of code between here and oracle_compat.c?
regards, tom lane
> >"Pavel Stehule" <pavel.stehule@hotmail.com> writes: > > this patch correct bug in to_char function with incorrect uppercased >month's > > or day's name. > >I still think this coding is unsafe in the case where the modified >string is longer than the original. Also, could we please not duplicate >such a large chunk of code between here and oracle_compat.c? > > regards, tom lane I hope so not. It's safe if argument "inout" is pointer on safety long buffer. Propably this function's can sit in somewhere else, but I expect so will for text and str, because without controls has only 2 lines of code. This patch is minimalistic, without others non neccesery changes. Regards Pavel Stehule _________________________________________________________________ Emotikony a pozadi programu MSN Messenger ozivi vasi konverzaci. http://messenger.msn.cz/
Re: this patch correct upper and lower case for translated month's and day's names
From
Bruce Momjian
Date:
Would you please modify this patch to use the functions in oracle_compat.c? --------------------------------------------------------------------------- Pavel Stehule wrote: > Hello, > > this patch correct bug in to_char function with incorrect uppercased month's > or day's name. > > Regards > Pavel Stehule > > _________________________________________________________________ > Najdete si svou lasku a nove pratele na Match.com. http://www.msn.cz/ [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 4: Have you searched our list archives? > > http://archives.postgresql.org -- Bruce Momjian bruce@momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +