Postgres Pro
Downloads
Home   >   mailing lists

Thread: psql patch

psql patch

From
Guillaume Lelarge
Date:
Hi all,

You'll find attached a small patch (CVS HEAD) to allow translation on
two psql strings.

Please apply, thanks.

Regards.


--
Guillaume.
Index: src/bin/psql/print.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/bin/psql/print.c,v
retrieving revision 1.89
diff -r1.89 print.c
853c853
<                     snprintf(record_str, 64, "* Record %lu", record++);
---
>                     snprintf(record_str, 64, _("* Record %lu"), record++);
855c855
<                     snprintf(record_str, 64, "[ RECORD %lu ]", record++);
---
>                     snprintf(record_str, 64, _("[ RECORD %lu ]"), record++);

Re: psql patch

From
Tom Lane
Date:
Guillaume Lelarge <guillaume@lelarge.info> writes:
> diff -r1.89 print.c
> 853c853
> <                     snprintf(record_str, 64, "* Record %lu", record++);
> ---
>> snprintf(record_str, 64, _("* Record %lu"), record++);
> 855c855
> <                     snprintf(record_str, 64, "[ RECORD %lu ]", record++);
> ---
>> snprintf(record_str, 64, _("[ RECORD %lu ]"), record++);

Hm, these strings were never localizable in previous versions; if we
make them so, do we risk breaking any code that examines psql output?

What about the equivalent headers in the other output formats?

            regards, tom lane

Re: psql patch

From
Guillaume Lelarge
Date:
Tom Lane a ecrit le 13/09/2006 18:05:
> Guillaume Lelarge <guillaume@lelarge.info> writes:
>> diff -r1.89 print.c
>> 853c853
>> <                     snprintf(record_str, 64, "* Record %lu", record++);
>> ---
>>> snprintf(record_str, 64, _("* Record %lu"), record++);
>> 855c855
>> <                     snprintf(record_str, 64, "[ RECORD %lu ]", record++);
>> ---
>>> snprintf(record_str, 64, _("[ RECORD %lu ]"), record++);
>
> Hm, these strings were never localizable in previous versions; if we
> make them so, do we risk breaking any code that examines psql output?
>

Don't know but I always thought tools shoudn't rely on strings output.

> What about the equivalent headers in the other output formats?
>

Which one ? can you give me an example ?

Regards.


--
Guillaume.