Thread: Re: [HACKERS] BF Failure on Bandicoot

Re: [HACKERS] BF Failure on Bandicoot

From
"Magnus Hagander"
Date:
> > Just guessing from the function name, but does this go away if you
> > don't configure --with-ldap?
> >
> > If so it's presumably a portability issue in this recent patch:
> >
> > 2006-03-06 12:41  momjian
> >
> >     * configure, configure.in, src/backend/libpq/auth.c,
> >     src/backend/libpq/hba.c,
> > src/backend/libpq/pg_hba.conf.sample,
> >     src/include/pg_config.h.in, src/include/libpq/hba.h: This patch
> >     adds native LDAP auth, for those platforms that don't have PAM
> >     (such as Win32, but also unixen without PAM). On Unix, uses
> >     OpenLDAP. On win32, uses the builin WinLDAP library.
> >
> >     Magnus Hagander
> >
> > I'd counsel just leaving --with-ldap off until Magnus gets
> back from
> > vacation.  We can always revert the patch later if he can't fix it.
> > (There's some fairly ugly stuff going on at lines 69-89 of
> > backend/libpq/auth.c, which I bet is the root of the
> trouble, but I'm
> > not going to dig further --- I've wasted more than enough time on
> > Windows this week ;-))

Attached is a patch that fixes this issue at least in my test machine
(yes, I found one 2000 machine that was broken as well)

//Magnus

Attachment

Re: [HACKERS] BF Failure on Bandicoot

From
Tom Lane
Date:
"Magnus Hagander" <mha@sollentuna.net> writes:
> Attached is a patch that fixes this issue at least in my test machine
> (yes, I found one 2000 machine that was broken as well)

Applied.  Dave, would you re-enable the LDAP option on bandicoot so
we can verify this fixes it?

            regards, tom lane

Re: [HACKERS] BF Failure on Bandicoot

From
"Dave Page"
Date:

> -----Original Message-----
> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> Sent: 21 August 2006 20:24
> To: pgsql-hackers@postgresql.org; Magnus Hagander
> Cc: Dave Page; pgsql-patches@postgresql.org
> Subject: Re: [PATCHES] [HACKERS] BF Failure on Bandicoot
>
> "Magnus Hagander" <mha@sollentuna.net> writes:
> > Attached is a patch that fixes this issue at least in my
> test machine
> > (yes, I found one 2000 machine that was broken as well)
>
> Applied.  Dave, would you re-enable the LDAP option on bandicoot so
> we can verify this fixes it?

Done. I think the next run is in a few hours on that box.

Regards, Dave.