Thread: WIP archive_timeout patch
WIP archive_timeout. All we need to do is add LWLock support to archiver. Thoughts/ideas/hints welcome. This is a patch-on-patch atop the xswitch.patch recently posted. -- Simon Riggs EnterpriseDB http://www.enterprisedb.com
Attachment
Simon Riggs <simon@2ndquadrant.com> writes:
> WIP archive_timeout.
> All we need to do is add LWLock support to archiver.
> Thoughts/ideas/hints welcome.
Hint: this isn't the archiver's problem, and so you don't need to get
the archiver involved in the solution. I'd suggest bgwriter as a
reasonably appropriate place instead.
regards, tom lane
On Thu, 2006-08-03 at 13:38 -0400, Tom Lane wrote: > Simon Riggs <simon@2ndquadrant.com> writes: > > WIP archive_timeout. > > All we need to do is add LWLock support to archiver. > > Thoughts/ideas/hints welcome. > > Hint: this isn't the archiver's problem, and so you don't need to get > the archiver involved in the solution. I'd suggest bgwriter as a > reasonably appropriate place instead. OK -- Simon Riggs EnterpriseDB http://www.enterprisedb.com
On Thu, 2006-08-03 at 19:03 +0100, Simon Riggs wrote: > On Thu, 2006-08-03 at 13:38 -0400, Tom Lane wrote: > > Simon Riggs <simon@2ndquadrant.com> writes: > > > WIP archive_timeout. > > > All we need to do is add LWLock support to archiver. > > > Thoughts/ideas/hints welcome. > > > > Hint: this isn't the archiver's problem, and so you don't need to get > > the archiver involved in the solution. I'd suggest bgwriter as a > > reasonably appropriate place instead. > > OK A slightly fuller answer: Yes, thats a safer place than archiver, so I'll add it to bgwriter as you suggest. Should have a patch complete by Tuesday, since travelling now. -- Simon Riggs EnterpriseDB http://www.enterprisedb.com
On Wed, 2006-08-16 at 10:09 +0100, Simon Riggs wrote: > On Thu, 2006-08-03 at 19:03 +0100, Simon Riggs wrote: > > On Thu, 2006-08-03 at 13:38 -0400, Tom Lane wrote: > > > Simon Riggs <simon@2ndquadrant.com> writes: > > > > WIP archive_timeout. > > > > All we need to do is add LWLock support to archiver. > > > > Thoughts/ideas/hints welcome. > > > > > > Hint: this isn't the archiver's problem, and so you don't need to get > > > the archiver involved in the solution. I'd suggest bgwriter as a > > > reasonably appropriate place instead. > > Revised patch enclosed, now believed to be production ready. This > implements regular log switching using the archive_timeout GUC. Further patch enclosed implementing these changes plus the record type version of pg_xlogfile_name_offset() -- Simon Riggs EnterpriseDB http://www.enterprisedb.com