Thread: MS-VC build patch

MS-VC build patch

From
"Hiroshi Saito"
Date:
Hi Bruce-san, and Magnus-san,

I have many problems by client construction of 8.2.
This patch helps a MS-VC client and server construction.
However, IPV6 still has the problem.
Please fully take into consideration.

Thanks.

Regards,
Hiroshi Saito


Attachment

Re: MS-VC build patch

From
"Magnus Hagander"
Date:
> Hi Bruce-san, and Magnus-san,
>
> I have many problems by client construction of 8.2.
> This patch helps a MS-VC client and server construction.
> However, IPV6 still has the problem.
> Please fully take into consideration.

Hi!

Hiroshi - why are you taking out all the stuff from pg_config.h.win32?
It's necessary to build the complete system on win32.

It's possible (I'd say now likely) that something in the client-only vc
build broke with the patch to allow full system build with vc. IIRC I
tested it before I sent it in, but some changes were made after
application - and it's possible I forgot to include something in the
patch.

As for the other parts - I haven't seen those problems, but I'm not
working off latest-and-greatest CVS. I need to merge up to that soon,
I'll take a look at it then.

//Magnus

Re: MS-VC build patch

From
Bruce Momjian
Date:
Hiroshi, I applied Magnus's patches.  Can you build cleanly now?

---------------------------------------------------------------------------

Hiroshi Saito wrote:
> Hi Bruce-san, and Magnus-san,
>
> I have many problems by client construction of 8.2.
> This patch helps a MS-VC client and server construction.
> However, IPV6 still has the problem.
> Please fully take into consideration.
>
> Thanks.
>
> Regards,
> Hiroshi Saito
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

Re: MS-VC build patch

From
"Hiroshi Saito"
Date:
Hi Bruce-san.

It does not help me yet. He uses VC2005.:-(
It seems that furthermore, it is still in the middle of work.
One problem is visible to the next.(win32.mak)
+   if not exist pg_config_os.h copy port\win32.h pg_config_os.h
If VC6+ is still supported, I will submit the patch again.
What I patch has built both the client and the server by VC6+.

Regards,
Hiroshi Saito

From: "Bruce Momjian"


>
> Hiroshi, I applied Magnus's patches.  Can you build cleanly now?
>
> ---------------------------------------------------------------------------
>
> Hiroshi Saito wrote:
> > Hi Bruce-san, and Magnus-san,
> >
> > I have many problems by client construction of 8.2.
> > This patch helps a MS-VC client and server construction.
> > However, IPV6 still has the problem.
> > Please fully take into consideration.
> >
> > Thanks.
> >
> > Regards,
> > Hiroshi Saito
> >
>
> [ Attachment, skipping... ]
>
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 6: explain analyze is your friend
>
> --
>   Bruce Momjian   bruce@momjian.us
>   EnterpriseDB    http://www.enterprisedb.com
>
>   + If your life is a hard drive, Christ can be your backup. +
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster

Re: MS-VC build patch

From
"Hiroshi Saito"
Date:
Umm, It is strange.. I think that you have another config.h.?
I look at much error by the reason for being realistic.
I will become on tomorrow night, since I am not in the machine
which can work now.

Regards,
Hiroshi Saito

From: "Magnus Hagander"


> Hi Bruce-san.
>
> It does not help me yet. He uses VC2005.:-( It seems that
> furthermore, it is still in the middle of work.
> One problem is visible to the next.(win32.mak)
> +   if not exist pg_config_os.h copy port\win32.h pg_config_os.h
> If VC6+ is still supported, I will submit the patch again.
> What I patch has built both the client and the server by VC6+.

I don't think there's anything specific in my patch that should kill
VC6. What specifically does not work in VC6?

(Just reverting the whole patch doesn't seem right to me...)

//Magnus

Re: MS-VC build patch

From
"Magnus Hagander"
Date:
> Hi Bruce-san.
>
> It does not help me yet. He uses VC2005.:-( It seems that
> furthermore, it is still in the middle of work.
> One problem is visible to the next.(win32.mak)
> +   if not exist pg_config_os.h copy port\win32.h pg_config_os.h
> If VC6+ is still supported, I will submit the patch again.
> What I patch has built both the client and the server by VC6+.

I don't think there's anything specific in my patch that should kill
VC6. What specifically does not work in VC6?

(Just reverting the whole patch doesn't seem right to me...)

//Magnus