Thread: archiver.pid
Lock file to prevent starting with multiple archivers present. Possibly some debate over exact behaviour, but publish early... -- Simon Riggs EnterpriseDB http://www.enterprisedb.com
Attachment
Simon Riggs wrote: > Lock file to prevent starting with multiple archivers present. Isn't it cleaner to remove the PID file in postmaster.c:reaper()? That way you are really sure that the PID file is removed when the process is gone, even if it crashes. OTOH I don't think it's very clean to change the semantics of the ArchPid variable in postmaster. We use those to keep track of the running process, so if there's no archiver, it should be 0 (which is true for all said variables). -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support
On Mon, 2006-05-22 at 17:29 +0100, Simon Riggs wrote: > Lock file to prevent starting with multiple archivers present. > > Possibly some debate over exact behaviour, but publish early... Original patch withdrawn. New patch included. -- Simon Riggs EnterpriseDB http://www.enterprisedb.com
Attachment
Patch applied to CVS HEAD and 8.1.X. Thanks. --------------------------------------------------------------------------- Simon Riggs wrote: > On Mon, 2006-05-22 at 17:29 +0100, Simon Riggs wrote: > > Lock file to prevent starting with multiple archivers present. > > > > Possibly some debate over exact behaviour, but publish early... > > Original patch withdrawn. > > New patch included. > > -- > Simon Riggs > EnterpriseDB http://www.enterprisedb.com [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 4: Have you searched our list archives? > > http://archives.postgresql.org -- Bruce Momjian http://candle.pha.pa.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +