Thread: Show tablespace for databases with psql's \l+

Show tablespace for databases with psql's \l+

From
Philip Yarra
Date:
Following discussion
(http://archives.postgresql.org/pgsql-hackers/2006-03/msg01208.php) here's a
patch to add tablespace to the output of psql's \l+. New output (with psql
-E) looks like this:

pyarra=# \l+
********* QUERY **********
SELECT d.datname as "Name",
       r.rolname as "Owner",
       pg_catalog.pg_encoding_to_char(d.encoding) as "Encoding",
       pg_catalog.shobj_description(d.oid, 'pg_database') as "Description",
       t.spcname as "Tablespace"
FROM pg_catalog.pg_database d
  JOIN pg_catalog.pg_roles r ON d.datdba = r.oid
  JOIN pg_catalog.pg_tablespace t on d.dattablespace = t.oid
ORDER BY 1;
**************************

                           List of databases
   Name    | Owner  | Encoding |        Description        | Tablespace
-----------+--------+----------+---------------------------+------------
 postgres  | pyarra | LATIN1   |                           | pg_default
 pyarra    | pyarra | LATIN1   |                           | pg_default
 spctest   | pyarra | LATIN1   |                           | spctable
 template0 | pyarra | LATIN1   |                           | pg_default
 template1 | pyarra | LATIN1   | Default template database | pg_default
(5 rows)

Please let me know if this patch needs any changes for acceptance. I would
prefer the tablespace row to the left of Description, but opted for minimal
change to get patch accepted. Will re-order them if others are in favour.

Regards, Philip.

-----------------
Utiba Pty Ltd
This message has been scanned for viruses and
dangerous content by Utiba mail server and is
believed to be clean.


Attachment

Re: Show tablespace for databases with psql's \l+

From
Tom Lane
Date:
Philip Yarra <philip@utiba.com> writes:
> Please let me know if this patch needs any changes for acceptance. I would
> prefer the tablespace row to the left of Description,

Me too --- that looks pretty weird as-is.

            regards, tom lane

Re: Show tablespace for databases with psql's \l+

From
Philip Yarra
Date:
On Thu, 30 Mar 2006 01:13 pm, Tom Lane wrote:
> Philip Yarra <philip@utiba.com> writes:
> > Please let me know if this patch needs any changes for acceptance. I
> > would prefer the tablespace row to the left of Description,
>
> Me too --- that looks pretty weird as-is.

OK, revised patch attached. Less-weird output now looks like this:

                           List of databases
   Name    | Owner  | Encoding | Tablespace |        Description
-----------+--------+----------+------------+---------------------------
 postgres  | pyarra | LATIN1   | pg_default |
 pyarra    | pyarra | LATIN1   | pg_default |
 spctest   | pyarra | LATIN1   | spctable   |
 template0 | pyarra | LATIN1   | pg_default |
 template1 | pyarra | LATIN1   | pg_default | Default template database
(5 rows)

Much nicer, I think.

Regards, Philip.

--

"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan

-----------------
Utiba Pty Ltd
This message has been scanned for viruses and
dangerous content by Utiba mail server and is
believed to be clean.


Attachment

Re: Show tablespace for databases with psql's \l+

From
Bruce Momjian
Date:
Patch applied.  Thanks.

---------------------------------------------------------------------------


Philip Yarra wrote:
> On Thu, 30 Mar 2006 01:13 pm, Tom Lane wrote:
> > Philip Yarra <philip@utiba.com> writes:
> > > Please let me know if this patch needs any changes for acceptance. I
> > > would prefer the tablespace row to the left of Description,
> >
> > Me too --- that looks pretty weird as-is.
>
> OK, revised patch attached. Less-weird output now looks like this:
>
>                            List of databases
>    Name    | Owner  | Encoding | Tablespace |        Description
> -----------+--------+----------+------------+---------------------------
>  postgres  | pyarra | LATIN1   | pg_default |
>  pyarra    | pyarra | LATIN1   | pg_default |
>  spctest   | pyarra | LATIN1   | spctable   |
>  template0 | pyarra | LATIN1   | pg_default |
>  template1 | pyarra | LATIN1   | pg_default | Default template database
> (5 rows)
>
> Much nicer, I think.
>
> Regards, Philip.
>
> --
>
> "Debugging is twice as hard as writing the code in the first place.
> Therefore, if you write the code as cleverly as possible, you are,
> by definition, not smart enough to debug it." - Brian W. Kernighan
>
> -----------------
> Utiba Pty Ltd
> This message has been scanned for viruses and
> dangerous content by Utiba mail server and is
> believed to be clean.
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
>        subscribe-nomail command to majordomo@postgresql.org so that your
>        message can get through to the mailing list cleanly

--
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +