Thread: shared description table.

shared description table.

From
Kris Jurka
Date:
I've created a new shared catalog table pg_shdescription to store comments
on cluster global objects like databases, tablespaces, and roles.

It touches a lot of places, but not much in the way of big changes.  The
only design decision I made was to duplicate the query and manipulation
functions rather than to try and have them handle both shared and local
comments.  I believe this is simpler for the code and not an issue for
callers because they know what type of object they are dealing with.  This
has resulted in a shobj_description function analagous to obj_description
and backend functions [Create/Delete]SharedComments mirroring the existing
[Create/Delete]Comments functions.

pg_shdescription.h goes into src/include/catalog/

Kris Jurka

Attachment

Re: shared description table.

From
Bruce Momjian
Date:
Patch applied.  Thanks.

---------------------------------------------------------------------------


Kris Jurka wrote:
>
> I've created a new shared catalog table pg_shdescription to store comments
> on cluster global objects like databases, tablespaces, and roles.
>
> It touches a lot of places, but not much in the way of big changes.  The
> only design decision I made was to duplicate the query and manipulation
> functions rather than to try and have them handle both shared and local
> comments.  I believe this is simpler for the code and not an issue for
> callers because they know what type of object they are dealing with.  This
> has resulted in a shobj_description function analagous to obj_description
> and backend functions [Create/Delete]SharedComments mirroring the existing
> [Create/Delete]Comments functions.
>
> pg_shdescription.h goes into src/include/catalog/
>
> Kris Jurka

Content-Description:

[ Attachment, skipping... ]

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073