Thread: Trivial permission problem with external-projects.sgml / and a typo in postgresql.conf.sample

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Hi,

- - The external-projects.sgml file has +x permissions unlike the other
files. Could you please fix it so that RPM checks won't compile?

- - ... and the attached patch fixes a trivial typo in
postgresql.conf.sample.

Regards,
- --
Devrim GUNDUZ
Kivi Bilişim Teknolojileri - http://www.kivi.com.tr
devrim~gunduz.org, devrim~PostgreSQL.org, devrim.gunduz~linux.org.tr
                       http://www.gunduz.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDch8v4zE8DGqpiZARAgsjAJ0ZLefgXsH7qf/lAgsT7hWuI+zV7wCdHa77
7bAZAAGF7FlkeDHQp3HW6j8=
=8feL
-----END PGP SIGNATURE-----

Devrim GUNDUZ <devrim@gunduz.org> writes:
> - - The external-projects.sgml file has +x permissions unlike the other
> files. Could you please fix it so that RPM checks won't compile?

A "find" turned up several other files that have +x and should not.
I removed +x permissions from all of these:

contrib/lo/Makefile
doc/src/sgml/external-projects.sgml
src/backend/catalog/system_views.sql
src/backend/port/tas/solaris_i386.s
src/backend/port/tas/solaris_sparc.s
src/pl/tcl/modules/pltcl_delmod.in
src/pl/tcl/modules/pltcl_listmod.in
src/pl/tcl/modules/pltcl_loadmod.in

For future reference, there was a previous discussion about this here:
http://archives.postgresql.org/pgsql-hackers/2003-11/msg01256.php
The way to fix a file's permission was outlined by Bruce.
What I did was:

ssh to cvs.postgresql.org
cd /cvsroot/pgsql/contrib/lo
cp -p Makefile,v Makefile,v.new
chmod -x Makefile,v.new
mv Makefile,v.new Makefile,v
etc

AFAIK any committer should have the privileges to do this.  Obviously
you want to be careful not to do it at the same time someone is
committing into the particular file ...

> - - ... and the attached patch fixes a trivial typo in
> postgresql.conf.sample.

Fixed, thanks.

            regards, tom lane