Thread: Bug in file access functions

The attached patch fixes a couple of minor issues in the file access
functions added for 8.1. These seem to have been introduced in recent
changes following the original patch.

1) Stop them rejecting paths that use Windows backslash directory
seperators.

2) Allow absolute paths to files into the data dir, as we already do for
the log dir. This allows queries like the following to work:

   select pg_stat_file((select setting from pg_settings where name =
'config_file'));

Without, a relative path must be constructed which is obviously
non-trivial in SQL.

Please apply for beta 2.

Regards, Dave

"Dave Page" <dpage@vale-housing.co.uk> writes:
> 1) Stop them rejecting paths that use Windows backslash directory
> seperators.

Hmm, seems like it should be using is_absolute_path().  Will fix.

> 2) Allow absolute paths to files into the data dir, as we already do for
> the log dir.

Seems reasonable, given that we expose the data dir path anyway.

            regards, tom lane

> -----Original Message-----
> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> Sent: 29 August 2005 20:15
> To: Dave Page
> Cc: PostgreSQL-patches
> Subject: Re: [PATCHES] Bug in file access functions
>
> "Dave Page" <dpage@vale-housing.co.uk> writes:
> > 1) Stop them rejecting paths that use Windows backslash directory
> > seperators.
>
> Hmm, seems like it should be using is_absolute_path().  Will fix.
>
> > 2) Allow absolute paths to files into the data dir, as we
> already do for
> > the log dir.
>
> Seems reasonable, given that we expose the data dir path anyway.

Thanks Tom.

Regards, Dave.