Thread: Re: [HACKERS] For review: Server instrumentation patch

Re: [HACKERS] For review: Server instrumentation patch

From
"Dave Page"
Date:

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 01 August 2005 14:47
> To: Dave Page
> Cc: Bruce Momjian; PostgreSQL-patches
> Subject: Re: [PATCHES] [HACKERS] For review: Server
> instrumentation patch
>
> Dave Page wrote:
> >
> >
> >
> >>-----Original Message-----
> >>From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
> >>Sent: 01 August 2005 03:26
> >>To: Dave Page
> >>Cc: PostgreSQL-patches
> >>Subject: Re: [HACKERS] For review: Server instrumentation patch
> >>
> >>Dave Page wrote:
> >>
> >>>[Resent as the list seems to have rejected yesterdays attempt]
> >>>
> >>>As per Bruce's request, here's a copy of Andreas' server
> >>>instrumentation patch for review. I've separated out the
> >>>dbsize stuff and pg_terminate_backend is also not included.
> >>>
> >>>This version was generated against CVS today.
> >>>
> >>>As far as I can tell from review of comments made back to
> >>>pre-8.0, all security and other concerns raised have been
> addressed.
> >>
> >>Here is a modified version of your patch that adds functions to do
> >>configuration file reload, and log file rotation.
> >
> >
> > OK, thanks. Are there any objections to adding pg_dir_ls() and
> > pg_file_read() which will allow us to look at the log
> directory, and the
> > logfiles themselves?
>
> pg_dir_ls isn't necessary for reading the logfiles;
> pg_logdir_ls will do
> this.

Err, yes, sorry - that was a thinko.

/D

Re: [HACKERS] For review: Server instrumentation patch

From
Andreas Pflug
Date:
Dave Page wrote:

>>
>>pg_dir_ls isn't necessary for reading the logfiles;
>>pg_logdir_ls will do
>>this.
>
>
> Err, yes, sorry - that was a thinko.

The list isn't complete. pgadmin uses these three functions for logfile
tracking:

- pg_logdir_ls to list logfiles
- pg_file_length to check for changes of the current logfile
- pg_file_read to retrieve a logfile

Regards,
Andreas