Thread: Patch to mention cost-based delay in vacuum reference

Patch to mention cost-based delay in vacuum reference

From
Alvaro Herrera
Date:
Hackers,

Subject says it all.  Please review the grammar ...

--
Alvaro Herrera (<alvherre[a]alvh.no-ip.org>)
"Et put se mouve" (Galileo Galilei)

Attachment

Re: Patch to mention cost-based delay in vacuum reference

From
Bruce Momjian
Date:
Updated patch applied.  Thanks.

---------------------------------------------------------------------------

Alvaro Herrera wrote:
> Hackers,
>
> Subject says it all.  Please review the grammar ...
>
> --
> Alvaro Herrera (<alvherre[a]alvh.no-ip.org>)
> "Et put se mouve" (Galileo Galilei)

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: ref/vacuum.sgml
===================================================================
RCS file: /home/alvherre/cvs/pgsql/doc/src/sgml/ref/vacuum.sgml,v
retrieving revision 1.36
diff -c -r1.36 vacuum.sgml
*** ref/vacuum.sgml    2 Dec 2004 19:28:48 -0000    1.36
--- ref/vacuum.sgml    29 Jul 2005 17:03:36 -0000
***************
*** 174,179 ****
--- 174,188 ----
      to occupy less disk space.  <command>VACUUM FULL</command> will usually
      shrink the table more than a plain <command>VACUUM</command> would.
     </para>
+
+    <para>
+     During <command>VACUUM</command> execution, there can be a substantial
+     increase in I/O traffic, which cause poor performance for other active
+     sessions.  Therefore, it is sometimes advisable to use
+     the cost-based vacuum delay feature.  See <xref
+     linkend="runtime" endterm="runtime-config-resource-vacuum-cost"> for more
+     details.
+    </para>
   </refsect1>

   <refsect1>
***************
*** 229,234 ****
--- 238,244 ----

    <simplelist type="inline">
     <member><xref linkend="app-vacuumdb" endterm="app-vacuumdb-title"></member>
+    <member><xref linkend="runtime" endterm="runtime-config-resource-vacuum-cost"></member>
    </simplelist>
   </refsect1>
  </refentry>

Re: P.tch to mention cost-based delay in vacuum reference

From
Alvaro Herrera
Date:
On Sat, Jul 30, 2005 at 11:46:37AM -0400, Bruce Momjian wrote:
>
> Updated patch applied.  Thanks.

Huh, something is very wrong with the markup:

http://candle.pha.pa.us/main/writings/pgsql/sgml/sql-vacuum.html

--
Alvaro Herrera (<alvherre[a]alvh.no-ip.org>)
"Having your biases confirmed independently is how scientific progress is
made, and hence made our great society what it is today" (Mary Gardiner)

Re: P.tch to mention cost-based delay in vacuum reference

From
Bruce Momjian
Date:
Alvaro Herrera wrote:
> On Sat, Jul 30, 2005 at 11:46:37AM -0400, Bruce Momjian wrote:
> >
> > Updated patch applied.  Thanks.
>
> Huh, something is very wrong with the markup:
>
> http://candle.pha.pa.us/main/writings/pgsql/sgml/sql-vacuum.html

OK, fixed.  link and linkend should not both be used.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: P.tch to mention cost-based delay in vacuum reference

From
Alvaro Herrera
Date:
On Sat, Jul 30, 2005 at 12:06:11PM -0400, Alvaro Herrera wrote:
> On Sat, Jul 30, 2005 at 11:46:37AM -0400, Bruce Momjian wrote:
> >
> > Updated patch applied.  Thanks.
>
> Huh, something is very wrong with the markup:
>
> http://candle.pha.pa.us/main/writings/pgsql/sgml/sql-vacuum.html

This should fix it.  Sorry.

--
Alvaro Herrera (<alvherre[a]alvh.no-ip.org>)
"Crear es tan difícil como ser libre" (Elsa Triolet)

Attachment

Re: P.tch to mention cost-based delay in vacuum reference

From
Alvaro Herrera
Date:
On Sat, Jul 30, 2005 at 01:04:28PM -0400, Bruce Momjian wrote:
> Alvaro Herrera wrote:
> > On Sat, Jul 30, 2005 at 11:46:37AM -0400, Bruce Momjian wrote:
> > >
> > > Updated patch applied.  Thanks.
> >
> > Huh, something is very wrong with the markup:
> >
> > http://candle.pha.pa.us/main/writings/pgsql/sgml/sql-vacuum.html
>
> OK, fixed.  link and linkend should not both be used.

Hmm.  I like my solution best because the section title will appear in
the link.

--
Alvaro Herrera (<alvherre[a]alvh.no-ip.org>)
"Porque Kim no hacia nada, pero, eso sí,
con extraordinario éxito" ("Kim", Kipling)

Re: P.tch to mention cost-based delay in vacuum reference

From
Bruce Momjian
Date:
OK, I backed out my fix and applied your, and tested the output.

---------------------------------------------------------------------------

Alvaro Herrera wrote:
> On Sat, Jul 30, 2005 at 12:06:11PM -0400, Alvaro Herrera wrote:
> > On Sat, Jul 30, 2005 at 11:46:37AM -0400, Bruce Momjian wrote:
> > >
> > > Updated patch applied.  Thanks.
> >
> > Huh, something is very wrong with the markup:
> >
> > http://candle.pha.pa.us/main/writings/pgsql/sgml/sql-vacuum.html
>
> This should fix it.  Sorry.
>
> --
> Alvaro Herrera (<alvherre[a]alvh.no-ip.org>)
> "Crear es tan dif?cil como ser libre" (Elsa Triolet)

[ Attachment, skipping... ]

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073