Thread: Re: patch for win32 dynloader
> >> 3) I restarted the postmaster both times. I got this error > both times. > >> :25: ERROR: could not load library "C:/Program > >> Files/PostgreSQL/8.0/lib/testtrigfuncs.dll": dynamic load error > > > Yes. We really need to look at fixing that error message. I had > > forgotten it completely :-( > > > Bruce, you think we can sneak that in after feature freeze? I would > > call it a bugfix :-) > > Me too. That's been on the radar for awhile --- please do > send in a patch. Here we go, that wasn't too hard :-) Apart from adding the error handling, it does one more thing: it changes the errormode when loading the DLLs. Previously if a DLL was broken, or referenced other DLLs that couldn't be found, a popup dialog box would appear on the screen. Which had to be clicked before the backend could continue. This patch also disables the popup error message for DLL loads. I think this is something we should consider doing for the entire backend - disable those popups, and say we deal with it ourselves. What do you other win32 hackers thinnk about this? In the meantime, this patch fixes the error msgs. Please apply for 8.1 and please consider a backpatch to 8.0. //Magnus
Attachment
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---------------------------------------------------------------------------
Magnus Hagander wrote:
> > >> 3) I restarted the postmaster both times. I got this error
> > both times.
> > >> :25: ERROR: could not load library "C:/Program
> > >> Files/PostgreSQL/8.0/lib/testtrigfuncs.dll": dynamic load error
> >
> > > Yes. We really need to look at fixing that error message. I had
> > > forgotten it completely :-(
> >
> > > Bruce, you think we can sneak that in after feature freeze? I would
> > > call it a bugfix :-)
> >
> > Me too. That's been on the radar for awhile --- please do
> > send in a patch.
>
> Here we go, that wasn't too hard :-)
>
> Apart from adding the error handling, it does one more thing: it changes
> the errormode when loading the DLLs. Previously if a DLL was broken, or
> referenced other DLLs that couldn't be found, a popup dialog box would
> appear on the screen. Which had to be clicked before the backend could
> continue. This patch also disables the popup error message for DLL
> loads.
>
>
> I think this is something we should consider doing for the entire
> backend - disable those popups, and say we deal with it ourselves. What
> do you other win32 hackers thinnk about this?
>
> In the meantime, this patch fixes the error msgs. Please apply for 8.1
> and please consider a backpatch to 8.0.
>
>
> //Magnus
Content-Description: win32_dynloader_err.patch
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Patch applied. Thanks. Backpatched to 8.0.X. --------------------------------------------------------------------------- Magnus Hagander wrote: > > >> 3) I restarted the postmaster both times. I got this error > > both times. > > >> :25: ERROR: could not load library "C:/Program > > >> Files/PostgreSQL/8.0/lib/testtrigfuncs.dll": dynamic load error > > > > > Yes. We really need to look at fixing that error message. I had > > > forgotten it completely :-( > > > > > Bruce, you think we can sneak that in after feature freeze? I would > > > call it a bugfix :-) > > > > Me too. That's been on the radar for awhile --- please do > > send in a patch. > > Here we go, that wasn't too hard :-) > > Apart from adding the error handling, it does one more thing: it changes > the errormode when loading the DLLs. Previously if a DLL was broken, or > referenced other DLLs that couldn't be found, a popup dialog box would > appear on the screen. Which had to be clicked before the backend could > continue. This patch also disables the popup error message for DLL > loads. > > > I think this is something we should consider doing for the entire > backend - disable those popups, and say we deal with it ourselves. What > do you other win32 hackers thinnk about this? > > In the meantime, this patch fixes the error msgs. Please apply for 8.1 > and please consider a backpatch to 8.0. > > > //Magnus Content-Description: win32_dynloader_err.patch [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 6: explain analyze is your friend -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073