Thread: WIP XLog Switch
WIP patch to perform a switch from one log file to next when we do a pg_stop_backup(), including wal replay handling at recovery time. Patch currently crashes server at various points, so don't stare too hard, but patch applies cleanly on cvstip, compiles and make checks. Main issue is the need to poke the xlog record pointer with a new value after the log switch. I'm a little uncertain about that approach and I'm very likely getting it wrong now. Better ideas welcome. Patch is incomplete in that it doesn't handle shutdown checkpoints as log switches in archive mode (yet) Also nothing in here about standby databases (yet) Any comments appreciated before I spend too much time on this. Best Regards, Simon Riggs
Attachment
On Tue, 2005-04-19 at 19:44 +0100, Simon Riggs wrote: > Main issue is the need to poke the xlog record pointer with a new value > after the log switch. I'm a little uncertain about that approach and I'm > very likely getting it wrong now. Better ideas welcome. Happier with that approach now. Working on other issues in code. Best Regards, Simon Riggs
Any farther on this? --------------------------------------------------------------------------- Simon Riggs wrote: > > WIP patch to perform a switch from one log file to next when we do a > pg_stop_backup(), including wal replay handling at recovery time. > > Patch currently crashes server at various points, so don't stare too > hard, but patch applies cleanly on cvstip, compiles and make checks. > > Main issue is the need to poke the xlog record pointer with a new value > after the log switch. I'm a little uncertain about that approach and I'm > very likely getting it wrong now. Better ideas welcome. > > Patch is incomplete in that it doesn't handle shutdown checkpoints as > log switches in archive mode (yet) > > Also nothing in here about standby databases (yet) > > Any comments appreciated before I spend too much time on this. > > Best Regards, Simon Riggs [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to majordomo@postgresql.org so that your > message can get through to the mailing list cleanly -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
On Fri, 2005-05-20 at 23:16 -0400, Bruce Momjian wrote: > Any farther on this? No, but it will be in by deadline. I need to make first base with partitioning before I can do this. Hence my (otherwise rude) ignoring of your sterling work on the exec logging patch. Best Regards, Simon Riggs
On Sat, 2005-05-21 at 18:38 +0100, Simon Riggs wrote: > On Fri, 2005-05-20 at 23:16 -0400, Bruce Momjian wrote: > > Any farther on this? > > No, but it will be in by deadline. > > I need to make first base with partitioning before I can do this. Hence > my (otherwise rude) ignoring of your sterling work on the exec logging > patch. If I were to complete this patch now over next few days, would anybody object to its inclusion in 8.1 beta? I don't like to leave things incomplete... Best Regards, Simon Riggs
Simon Riggs wrote: > On Sat, 2005-05-21 at 18:38 +0100, Simon Riggs wrote: > > On Fri, 2005-05-20 at 23:16 -0400, Bruce Momjian wrote: > > > Any farther on this? > > > > No, but it will be in by deadline. > > > > I need to make first base with partitioning before I can do this. Hence > > my (otherwise rude) ignoring of your sterling work on the exec logging > > patch. > > If I were to complete this patch now over next few days, would anybody > object to its inclusion in 8.1 beta? > > I don't like to leave things incomplete... Please send us what you have when you are done and we will review it. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073