Thread: more fixes for making contrib null safe

more fixes for making contrib null safe

From
Kris Jurka
Date:
This adds the strict function attribute to the places in contrib that
crash on null inputs.

Kris Jurka

Attachment

Re: more fixes for making contrib null safe

From
Jon Jensen
Date:
On Fri, 28 Jan 2005, Kris Jurka wrote:

> This adds the strict function attribute to the places in contrib that
> crash on null inputs.

Doesn't C need to be quoted? A few of those looked like this:

LANGUAGE C STRICT

but I thought it should be:

LANGUAGE 'C' STRICT

Is that right?

Jon


--
Jon Jensen
End Point Corporation
http://www.endpoint.com/
Software development with Interchange, Perl, PostgreSQL, Apache, Linux, ...

Re: more fixes for making contrib null safe

From
Kris Jurka
Date:

On Sat, 29 Jan 2005, Jon Jensen wrote:

> On Fri, 28 Jan 2005, Kris Jurka wrote:
>
> > This adds the strict function attribute to the places in contrib that
> > crash on null inputs.
>
> Doesn't C need to be quoted? A few of those looked like this:
>
> LANGUAGE C STRICT
>

This is perfectly legal:

http://developer.postgresql.org/docs/postgres/sql-createfunction.html

langname

    The name of the language that the function is implemented in. May be
SQL, C, internal, or the name of a user-defined procedural language. For
backward compatibility, the name may be enclosed by single quotes.

Kris Jurka

Re: more fixes for making contrib null safe

From
Jon Jensen
Date:
On Fri, 28 Jan 2005, Kris Jurka wrote:

>> Doesn't C need to be quoted? A few of those looked like this:
>>
>> LANGUAGE C STRICT
>>
>
> This is perfectly legal:
>
> http://developer.postgresql.org/docs/postgres/sql-createfunction.html
>
> langname
>
>    The name of the language that the function is implemented in. May be
> SQL, C, internal, or the name of a user-defined procedural language. For
> backward compatibility, the name may be enclosed by single quotes.

Oh, ok. Good to know.

Thanks,
Jon


--
Jon Jensen
End Point Corporation
http://www.endpoint.com/
Software development with Interchange, Perl, PostgreSQL, Apache, Linux, ...

Re: more fixes for making contrib null safe

From
Tom Lane
Date:
Kris Jurka <books@ejurka.com> writes:
> This adds the strict function attribute to the places in contrib that
> crash on null inputs.

Sounds good.  Barring objections, I'll apply this to current and back
branches before we make the upcoming releases.

            regards, tom lane