Thread: pg_dumplo schema support

pg_dumplo schema support

From
Karel Zak
Date:
Hi,

it looks users still use pg_dumplo from contrib tree:

On Thu, 2004-11-18 at 17:45 +0100, Düster Horst wrote:
> Hallo Karel
>
> I tried to use your pg_dumplo but it seems, that the version
> contributed with pg-7.4.5 does not support schemas.

here is a patch with:

* support absolute paths in dump index
* support for schemas
* queries to catalog uses "pg_catalog." prefix
* default directory is $PWD or "."
* check index file format
* schema support is backward compatible (default schema is "public")

Maybe it's too late for 8.0, but I think nobody test it during beta
releases. I tested it now with this patch and it works for me. If you
think that 8.1 will better, please apply it to 8.1.

Thanks,
    Karel

--
Karel Zak <kzak@redhat.com>

Attachment

Re: pg_dumplo schema support

From
Tom Lane
Date:
Karel Zak <kzak@redhat.com> writes:
> here is a patch with:

> * support absolute paths in dump index
> * support for schemas
> * queries to catalog uses "pg_catalog." prefix
> * default directory is $PWD or "."
> * check index file format
> * schema support is backward compatible (default schema is "public")

Applied.

> Maybe it's too late for 8.0, but I think nobody test it during beta
> releases. I tested it now with this patch and it works for me. If you
> think that 8.1 will better, please apply it to 8.1.

If it were part of the main tree then I'd be a bit more worried, but
the standards in contrib are looser --- and anyway, most of this
can be interpreted as bug fixes.

            regards, tom lane