Thread: Patch pg_start_backup() to ERROR if archiving is not defined

Patch pg_start_backup() to ERROR if archiving is not defined

From
Gavin Sherry
Date:
Hi all,

Attached is a patch which checks early on in pg_start_back() that
archive_command is defined and if not generates an error. This seemed like
a reason foot gun prevention measure.

Gavin

Attachment

Re: Patch pg_start_backup() to ERROR if archiving is not

From
Neil Conway
Date:
On Sun, 2004-11-14 at 23:05 +1100, Gavin Sherry wrote:
> Attached is a patch which checks early on in pg_start_back() that
> archive_command is defined and if not generates an error. This seemed like
> a reason foot gun prevention measure.

I'll apply this before end of day today.

-Neil



Re: Patch pg_start_backup() to ERROR if archiving is not

From
Neil Conway
Date:
On Sun, 2004-11-14 at 23:05 +1100, Gavin Sherry wrote:
> Attached is a patch which checks early on in pg_start_back() that
> archive_command is defined and if not generates an error.

Applied, with some tweaks.

Thanks.

-Neil