Thread: win32 cleanup

win32 cleanup

From
Andrew Dunstan
Date:
The attached patch adds a few prototypes and does a typecast, thus
removing some harmless but annoying compile warnings on Win32.

cheers

andrew
Index: src/backend/port/dynloader/win32.c
===================================================================
RCS file: /home/cvsmirror/pgsql/src/backend/port/dynloader/win32.c,v
retrieving revision 1.3
diff -c -r1.3 win32.c
*** src/backend/port/dynloader/win32.c    29 Nov 2003 19:51:54 -0000    1.3
--- src/backend/port/dynloader/win32.c    7 Nov 2004 22:22:09 -0000
***************
*** 2,7 ****
--- 2,12 ----

  #include <windows.h>

+ char * dlerror(void);
+ int dlclose(void * handle);
+ void * dlsym(void * habdle, const char *symbol);
+ void * dlopen(const char *path, int mode);
+
  char *
  dlerror(void)
  {
Index: src/backend/postmaster/postmaster.c
===================================================================
RCS file: /home/cvsmirror/pgsql/src/backend/postmaster/postmaster.c,v
retrieving revision 1.436
diff -c -r1.436 postmaster.c
*** src/backend/postmaster/postmaster.c    2 Nov 2004 03:34:50 -0000    1.436
--- src/backend/postmaster/postmaster.c    7 Nov 2004 22:22:10 -0000
***************
*** 3735,3741 ****
                       */
                      ereport(FATAL,
                              (errmsg_internal("failed to get exit code for child %lu",
!                                            win32_childPIDArray[index])));
                  }
                  *exitstatus = (int) exitCode;
                  return win32_childPIDArray[index];
--- 3735,3741 ----
                       */
                      ereport(FATAL,
                              (errmsg_internal("failed to get exit code for child %lu",
!                                            (unsigned long) win32_childPIDArray[index])));
                  }
                  *exitstatus = (int) exitCode;
                  return win32_childPIDArray[index];
Index: src/port/open.c
===================================================================
RCS file: /home/cvsmirror/pgsql/src/port/open.c,v
retrieving revision 1.5
diff -c -r1.5 open.c
*** src/port/open.c    17 Oct 2004 23:53:30 -0000    1.5
--- src/port/open.c    7 Nov 2004 22:22:11 -0000
***************
*** 18,23 ****
--- 18,25 ----
  #include <errno.h>
  #include <assert.h>

+ int win32_open(const char *fileName, int fileFlags, ...);
+
  static int
  openFlagsToCreateFileFlags(int openFlags)
  {

Re: win32 cleanup

From
Neil Conway
Date:
On Sun, 2004-11-07 at 17:50 -0500, Andrew Dunstan wrote:
> The attached patch adds a few prototypes and does a typecast, thus
> removing some harmless but annoying compile warnings on Win32.

Applied.

-Neil