Postgres Pro
Downloads
Home   >   mailing lists

Thread: Win32 psql fix

Win32 psql fix

From
"Dave Page"
Date:
The attached patch fixes psql's win32 frontend-only build, by using
pg_strcasecmp in variables.c, and #ifdef'ing out PostmasterPid in
miscadmin.h.

Please apply.

Regards Dave.
Attachment

Re: Win32 psql fix

From
Bruce Momjian
Date:
Patch applied.  Thanks.

---------------------------------------------------------------------------


Dave Page wrote:
> The attached patch fixes psql's win32 frontend-only build, by using
> pg_strcasecmp in variables.c, and #ifdef'ing out PostmasterPid in
> miscadmin.h.
>
> Please apply.
>
> Regards Dave.

Content-Description: psql.diff

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if your
>       joining column's datatypes do not match

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: Win32 psql fix

From
Tom Lane
Date:
"Dave Page" <dpage@vale-housing.co.uk> writes:
> The attached patch fixes psql's win32 frontend-only build, by using
> pg_strcasecmp in variables.c, and #ifdef'ing out PostmasterPid in
> miscadmin.h.

What in the world is client-side code doing including miscadmin.h
in the first place?

            regards, tom lane

Re: Win32 psql fix

From
Bruce Momjian
Date:
Tom Lane wrote:
> "Dave Page" <dpage@vale-housing.co.uk> writes:
> > The attached patch fixes psql's win32 frontend-only build, by using
> > pg_strcasecmp in variables.c, and #ifdef'ing out PostmasterPid in
> > miscadmin.h.
>
> What in the world is client-side code doing including miscadmin.h
> in the first place?

Ah, it is getting included from the port files.  Let me see if I can fix
that with FRONTEND tests.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: Win32 psql fix

From
"Dave Page"
Date:

> -----Original Message-----
> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> Sent: 18 October 2004 18:37
> To: Dave Page
> Cc: PostgreSQL-patches
> Subject: Re: [PATCHES] Win32 psql fix
>
> "Dave Page" <dpage@vale-housing.co.uk> writes:
> > The attached patch fixes psql's win32 frontend-only build, by using
> > pg_strcasecmp in variables.c, and #ifdef'ing out PostmasterPid in
> > miscadmin.h.
>
> What in the world is client-side code doing including
> miscadmin.h in the first place?

It's included by port/exec.c which contains functions like find_my_exec.

Regards, Dave