Thread: Win32 Version numbering patch

Win32 Version numbering patch

From
"Dave Page"
Date:
I was hoping this would be in for beta 3, but alas - can someone
*please* commit the win32 version patch at:

http://candle.pha.pa.us/mhonarc/patches/msg00000.html

With the correction at

http://candle.pha.pa.us/mhonarc/patches/msg00001.html

Without it we cannot reliably install files like libpq.dll on Windows!!

Regards, Dave

Re: Win32 Version numbering patch

From
"Magnus Hagander"
Date:
> I was hoping this would be in for beta 3, but alas - can someone
> *please* commit the win32 version patch at:
>
> http://candle.pha.pa.us/mhonarc/patches/msg00000.html
>
> With the correction at
>
> http://candle.pha.pa.us/mhonarc/patches/msg00001.html
>
> Without it we cannot reliably install files like libpq.dll on
> Windows!!

To be fair, the patch for libpq.dll specifically was applied and is
included in beta3 (I think), per
http://archives.postgresql.org/pgsql-committers/2004-09/msg00275.php.
That said, the other one is fairly badly needed as well...

//Magnus


Re: Win32 Version numbering patch

From
"Dave Page"
Date:

> -----Original Message-----
> From: Magnus Hagander [mailto:mha@sollentuna.net]
> Sent: 27 September 2004 11:26
> To: Dave Page; pgsql-hackers@postgresql.org
> Cc: PostgreSQL-patches
> Subject: RE: [PATCHES] Win32 Version numbering patch
>
> > I was hoping this would be in for beta 3, but alas - can someone
> > *please* commit the win32 version patch at:
> >
> > http://candle.pha.pa.us/mhonarc/patches/msg00000.html
> >
> > With the correction at
> >
> > http://candle.pha.pa.us/mhonarc/patches/msg00001.html
> >
> > Without it we cannot reliably install files like libpq.dll on
> > Windows!!
>
> To be fair, the patch for libpq.dll specifically was applied
> and is included in beta3 (I think), per
> http://archives.postgresql.org/pgsql-committers/2004-09/msg00275.php.
> That said, the other one is fairly badly needed as well...

Yup, sorry. I was looking for the .ico file...

Regards, Dave.

Re: [HACKERS] Win32 Version numbering patch

From
Bruce Momjian
Date:
Dave Page wrote:
>
>
> > -----Original Message-----
> > From: Magnus Hagander [mailto:mha@sollentuna.net]
> > Sent: 27 September 2004 11:26
> > To: Dave Page; pgsql-hackers@postgresql.org
> > Cc: PostgreSQL-patches
> > Subject: RE: [PATCHES] Win32 Version numbering patch
> >
> > > I was hoping this would be in for beta 3, but alas - can someone
> > > *please* commit the win32 version patch at:
> > >
> > > http://candle.pha.pa.us/mhonarc/patches/msg00000.html
> > >
> > > With the correction at
> > >
> > > http://candle.pha.pa.us/mhonarc/patches/msg00001.html
> > >
> > > Without it we cannot reliably install files like libpq.dll on
> > > Windows!!
> >
> > To be fair, the patch for libpq.dll specifically was applied
> > and is included in beta3 (I think), per
> > http://archives.postgresql.org/pgsql-committers/2004-09/msg00275.php.
> > That said, the other one is fairly badly needed as well...
>
> Yup, sorry. I was looking for the .ico file...

Now that I am back I can apply it soon.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: [HACKERS] Win32 Version numbering patch

From
Tom Lane
Date:
"Dave Page" <dpage@vale-housing.co.uk> writes:
> I was hoping this would be in for beta 3, but alas - can someone
> *please* commit the win32 version patch at:
> http://candle.pha.pa.us/mhonarc/patches/msg00000.html

Personally I was holding off in hopes of seeing a cleaner solution.
A patch that requires every executable-building Makefile to have a
platform-specific wart isn't going to be very maintainable.  You
already missed pg_config, plus whichever of the contrib modules build
executables...

            regards, tom lane

Re: [HACKERS] Win32 Version numbering patch

From
Bruce Momjian
Date:
Tom Lane wrote:
> "Dave Page" <dpage@vale-housing.co.uk> writes:
> > I was hoping this would be in for beta 3, but alas - can someone
> > *please* commit the win32 version patch at:
> > http://candle.pha.pa.us/mhonarc/patches/msg00000.html
>
> Personally I was holding off in hopes of seeing a cleaner solution.
> A patch that requires every executable-building Makefile to have a
> platform-specific wart isn't going to be very maintainable.  You
> already missed pg_config, plus whichever of the contrib modules build
> executables...

I have added Win32 version information for pg_config.  I assume anyone
adding a new client binary will copy an existing one so I am hopeful the
win32 version strings will be maintained.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073