Thread: Re: [pgsql-hackers-win32] Service startup delay

Re: [pgsql-hackers-win32] Service startup delay

From
"Dave Page"
Date:

> -----Original Message-----
> From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
> Sent: 26 August 2004 02:44
> To: Max Dunn
> Cc: Dave Page; 'Barry Lind'; pgsql-hackers-win32@postgresql.org
> Subject: Re: [pgsql-hackers-win32] Service startup delay
>
> > Another issue is that when installing the Postgres service with
> > "pg_ctl register -w ...." the "-w" parameter was not put in
> the registry "ImagePath"
> > value for the Postgres service. (I added it manually to test.) So I
> > suspect that "pg_ctl register" will need to be enhanced to add the
> > "-w" parameter to the registry settings.
>
> Would a Win32 guy look at this?

No problem.

Regards, Dave.

===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/bin/pg_ctl/pg_ctl.c,v
retrieving revision 1.25
diff -u -r1.25 pg_ctl.c
--- pg_ctl.c    21 Aug 2004 03:12:55 -0000    1.25
+++ pg_ctl.c    26 Aug 2004 14:37:13 -0000
@@ -832,6 +832,9 @@
         strcat(cmdLine,"\"");
     }

+    if (do_wait)
+        strcat(cmdLine, " -w");
+
     if (post_opts)
     {
         strcat(cmdLine," ");
@@ -1038,7 +1041,7 @@
     printf(_("  %s status  [-D DATADIR]\n"), progname);
     printf(_("  %s kill    SIGNALNAME PROCESSID\n"), progname);
 #ifdef WIN32
-    printf(_("  %s register   [-N servicename] [-U username] [-P
password] [-D DATADIR] [-o \"OPTIONS\"]\n"), progname);
+    printf(_("  %s register   [-N servicename] [-U username] [-P
password] [-D DATADIR] [-w] [-o \"OPTIONS\"]\n"), progname);
     printf(_("  %s unregister [-N servicename]\n"), progname);
 #endif
     printf(_("Common options:\n"));

Re: [pgsql-hackers-win32] Service startup delay

From
Bruce Momjian
Date:
Patch applied.  Thanks.

---------------------------------------------------------------------------


Dave Page wrote:
>
>
> > -----Original Message-----
> > From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
> > Sent: 26 August 2004 02:44
> > To: Max Dunn
> > Cc: Dave Page; 'Barry Lind'; pgsql-hackers-win32@postgresql.org
> > Subject: Re: [pgsql-hackers-win32] Service startup delay
> >
> > > Another issue is that when installing the Postgres service with
> > > "pg_ctl register -w ...." the "-w" parameter was not put in
> > the registry "ImagePath"
> > > value for the Postgres service. (I added it manually to test.) So I
> > > suspect that "pg_ctl register" will need to be enhanced to add the
> > > "-w" parameter to the registry settings.
> >
> > Would a Win32 guy look at this?
>
> No problem.
>
> Regards, Dave.
>
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/src/bin/pg_ctl/pg_ctl.c,v
> retrieving revision 1.25
> diff -u -r1.25 pg_ctl.c
> --- pg_ctl.c    21 Aug 2004 03:12:55 -0000    1.25
> +++ pg_ctl.c    26 Aug 2004 14:37:13 -0000
> @@ -832,6 +832,9 @@
>          strcat(cmdLine,"\"");
>      }
>
> +    if (do_wait)
> +        strcat(cmdLine, " -w");
> +
>      if (post_opts)
>      {
>          strcat(cmdLine," ");
> @@ -1038,7 +1041,7 @@
>      printf(_("  %s status  [-D DATADIR]\n"), progname);
>      printf(_("  %s kill    SIGNALNAME PROCESSID\n"), progname);
>  #ifdef WIN32
> -    printf(_("  %s register   [-N servicename] [-U username] [-P
> password] [-D DATADIR] [-o \"OPTIONS\"]\n"), progname);
> +    printf(_("  %s register   [-N servicename] [-U username] [-P
> password] [-D DATADIR] [-w] [-o \"OPTIONS\"]\n"), progname);
>      printf(_("  %s unregister [-N servicename]\n"), progname);
>  #endif
>      printf(_("Common options:\n"));
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073