Thread: Re: [pgsql-hackers-win32] 8.0 Beta 1 // Environment Vars // .pgpass
> -----Original Message----- > From: pgsql-hackers-win32-owner@postgresql.org > [mailto:pgsql-hackers-win32-owner@postgresql.org] On Behalf > Of Bruce Momjian > Sent: 18 August 2004 03:59 > To: Andrew Dunstan > Cc: Joerg Hessdoerfer; pgsql-hackers-win32@postgresql.org; > PostgreSQL-patches > Subject: Re: [pgsql-hackers-win32] 8.0 Beta 1 // Environment > Vars // .pgpass > > > I have applied the attached patch which adds get_home_path() > which uses USERPROFILE on Win32 and HOME on Unix. > > This should fix the reported problem. I now get the following error on Win32 following a make distclean: fe-connect.o(.text+0x3428):fe-connect.c: undefined reference to `get_home_path' c:\mingw\bin\dllwrap.exe: c:\mingw\bin\gcc exited with status 1 make[3]: *** [libpq.a] Error 1 make[3]: Leaving directory `/cvs/pgsql/src/interfaces/libpq' make[2]: *** [all] Error 2 make[2]: Leaving directory `/cvs/pgsql/src/interfaces' make[1]: *** [all] Error 2 make[1]: Leaving directory `/cvs/pgsql/src' make: *** [all] Error 2 :-( Regards, Dave.
Wow, that is strange. Did you do a 'make clean' before this? I don't see why you would see the failure on Win32 and I don't see it on Unix. Hold, we might have problems later on this for linking client apps because as I remember win32 doesn't like the same symbol used in libpq and pgport, but you haven't even gotten to that stage yet in the compile. The workaround has been to make the function call a macro but let's get libpq compiled first and see how it goes after that. --------------------------------------------------------------------------- Dave Page wrote: > > > > -----Original Message----- > > From: pgsql-hackers-win32-owner@postgresql.org > > [mailto:pgsql-hackers-win32-owner@postgresql.org] On Behalf > > Of Bruce Momjian > > Sent: 18 August 2004 03:59 > > To: Andrew Dunstan > > Cc: Joerg Hessdoerfer; pgsql-hackers-win32@postgresql.org; > > PostgreSQL-patches > > Subject: Re: [pgsql-hackers-win32] 8.0 Beta 1 // Environment > > Vars // .pgpass > > > > > > I have applied the attached patch which adds get_home_path() > > which uses USERPROFILE on Win32 and HOME on Unix. > > > > This should fix the reported problem. > > I now get the following error on Win32 following a make distclean: > > fe-connect.o(.text+0x3428):fe-connect.c: undefined reference to > `get_home_path' > c:\mingw\bin\dllwrap.exe: c:\mingw\bin\gcc exited with status 1 > make[3]: *** [libpq.a] Error 1 > make[3]: Leaving directory `/cvs/pgsql/src/interfaces/libpq' > make[2]: *** [all] Error 2 > make[2]: Leaving directory `/cvs/pgsql/src/interfaces' > make[1]: *** [all] Error 2 > make[1]: Leaving directory `/cvs/pgsql/src' > make: *** [all] Error 2 > > :-( > > Regards, Dave. > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
I found the cause and just applied a fix. Thanks. --------------------------------------------------------------------------- Bruce Momjian wrote: > > Wow, that is strange. Did you do a 'make clean' before this? I don't > see why you would see the failure on Win32 and I don't see it on Unix. > > Hold, we might have problems later on this for linking client apps > because as I remember win32 doesn't like the same symbol used in libpq > and pgport, but you haven't even gotten to that stage yet in the > compile. The workaround has been to make the function call a macro but > let's get libpq compiled first and see how it goes after that. > > --------------------------------------------------------------------------- > > Dave Page wrote: > > > > > > > -----Original Message----- > > > From: pgsql-hackers-win32-owner@postgresql.org > > > [mailto:pgsql-hackers-win32-owner@postgresql.org] On Behalf > > > Of Bruce Momjian > > > Sent: 18 August 2004 03:59 > > > To: Andrew Dunstan > > > Cc: Joerg Hessdoerfer; pgsql-hackers-win32@postgresql.org; > > > PostgreSQL-patches > > > Subject: Re: [pgsql-hackers-win32] 8.0 Beta 1 // Environment > > > Vars // .pgpass > > > > > > > > > I have applied the attached patch which adds get_home_path() > > > which uses USERPROFILE on Win32 and HOME on Unix. > > > > > > This should fix the reported problem. > > > > I now get the following error on Win32 following a make distclean: > > > > fe-connect.o(.text+0x3428):fe-connect.c: undefined reference to > > `get_home_path' > > c:\mingw\bin\dllwrap.exe: c:\mingw\bin\gcc exited with status 1 > > make[3]: *** [libpq.a] Error 1 > > make[3]: Leaving directory `/cvs/pgsql/src/interfaces/libpq' > > make[2]: *** [all] Error 2 > > make[2]: Leaving directory `/cvs/pgsql/src/interfaces' > > make[1]: *** [all] Error 2 > > make[1]: Leaving directory `/cvs/pgsql/src' > > make: *** [all] Error 2 > > > > :-( > > > > Regards, Dave. > > > > -- > Bruce Momjian | http://candle.pha.pa.us > pgman@candle.pha.pa.us | (610) 359-1001 > + If your life is a hard drive, | 13 Roberts Road > + Christ can be your backup. | Newtown Square, Pennsylvania 19073 > > ---------------------------(end of broadcast)--------------------------- > TIP 4: Don't 'kill -9' the postmaster > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073