Thread: Postgresql.conf Documentation change

Postgresql.conf Documentation change

From
Josh Berkus
Date:
Tom,

Attached is that patch I talked to you about on hackers.   It changes the
description at the top and uncomments most (but not all) of the lines in an
effort to make it clear that commenting is not a way to restore the defaults.

I've tested this on my machine and we end up with the exact same defaults with
this patch as without, so no changes to initdb should be required.

--
-Josh Berkus

______AGLIO DATABASE SOLUTIONS___________________________
                                        Josh Berkus
    Enterprise vertical business        josh@agliodbs.com
     and data analysis solutions        (415) 752-2500
      and database optimization           fax 752-2387
  utilizing Open Source technology      San Francisco

Attachment

Re: Postgresql.conf Documentation change

From
Bruce Momjian
Date:
What would people like done with this patch?  A sample section is:

! datestyle = 'iso, mdy'
! #timezone = {enviroment}        # actually, defaults to TZ environment setting
!                                 # set at initdb time
! australian_timezones = false
! extra_float_digits = 0          # min -15, max 2
! #client_encoding = {db encoding} # actually, defaults to database encoding
!                                 # common: UNICODE, SQL_ASCII

He has kept comments on the items where we can't determine a default.

One issue is that the postgresql.conf file only gets installed as part
of initdb so a shutdown/install/restart will replace the sample file,
but the server file will retain comments until an initdb.  This means
some beta people might go into 8.0.0 final with comments, and some will
not.

---------------------------------------------------------------------------

Josh Berkus wrote:
> Tom,
>
> Attached is that patch I talked to you about on hackers.   It changes the
> description at the top and uncomments most (but not all) of the lines in an
> effort to make it clear that commenting is not a way to restore the defaults.
>
> I've tested this on my machine and we end up with the exact same defaults with
> this patch as without, so no changes to initdb should be required.
>
> --
> -Josh Berkus
>
> ______AGLIO DATABASE SOLUTIONS___________________________
>                                         Josh Berkus
>     Enterprise vertical business        josh@agliodbs.com
>      and data analysis solutions        (415) 752-2500
>       and database optimization           fax 752-2387
>   utilizing Open Source technology      San Francisco

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: Postgresql.conf Documentation change

From
Josh Berkus
Date:
Bruce,

> One issue is that the postgresql.conf file only gets installed as part
> of initdb so a shutdown/install/restart will replace the sample file,
> but the server file will retain comments until an initdb.  This means
> some beta people might go into 8.0.0 final with comments, and some will
> not.

I think there's a couple other patches that have the same effect (that is,
initdb is required to take care of them).   I think people using the beta
should expect to re-build several times, anyway -- if they're not, they
shouldn't use beta software.

Also, this is basically a "documentation" bug, intended to make
postgresql.conf easier to understand, so even if some beta tester doesn't
load it, postgresql.conf still works ..

--
Josh Berkus
Aglio Database Solutions
San Francisco

Re: Postgresql.conf Documentation change

From
"Marc G. Fournier"
Date:
On Mon, 16 Aug 2004, Josh Berkus wrote:

> Bruce,
>
>> One issue is that the postgresql.conf file only gets installed as part
>> of initdb so a shutdown/install/restart will replace the sample file,
>> but the server file will retain comments until an initdb.  This means
>> some beta people might go into 8.0.0 final with comments, and some will
>> not.
>
> I think there's a couple other patches that have the same effect (that is,
> initdb is required to take care of them).   I think people using the beta
> should expect to re-build several times, anyway -- if they're not, they
> shouldn't use beta software.

Actually, I agree with this, but from a different angle ... if testing
beta, part of that testing is that an initdb does what is expected and
doesn't generate any errors/problems ... when we go into RC mode, *then*
things should be safe from an initdb, but beta shouldn't have that
requirement ...

----
Marc G. Fournier           Hub.Org Networking Services (http://www.hub.org)
Email: scrappy@hub.org           Yahoo!: yscrappy              ICQ: 7615664

Re: Postgresql.conf Documentation change

From
Bruce Momjian
Date:
Patch withdrawn to be revisited in 8.1.

---------------------------------------------------------------------------

Josh Berkus wrote:
> Tom,
>
> Attached is that patch I talked to you about on hackers.   It changes the
> description at the top and uncomments most (but not all) of the lines in an
> effort to make it clear that commenting is not a way to restore the defaults.
>
> I've tested this on my machine and we end up with the exact same defaults with
> this patch as without, so no changes to initdb should be required.
>
> --
> -Josh Berkus
>
> ______AGLIO DATABASE SOLUTIONS___________________________
>                                         Josh Berkus
>     Enterprise vertical business        josh@agliodbs.com
>      and data analysis solutions        (415) 752-2500
>       and database optimization           fax 752-2387
>   utilizing Open Source technology      San Francisco

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073