Thread: add build utilities in default install

add build utilities in default install

From
Fabien COELHO
Date:
Dear patchers,

Please find attached my first submission for installing all necessary
build files (makefile, scripts...) by default.

 - for the old behavior, do a "make light-install"

 - "make install" installs headers and other necessary files
   such as scripts and makefiles, for postgresql extensions
   to be build.

 - these files are installed in "pg_config --insbuilddir"
   the actual directory can be modified during configure with
   "--with-insbuilddir=DIR" option. Default is LIBDIR/build

 - the installation documentation is updated.

 - I also added a "install-client-only" target so as to simplify the doc.


What is yet to be done:

 - check that all necessary files are really there...
   esp. wrt win32/cygwin

 - provide an example makefile (script?) to build extensions, and install it!
   I'm planning to do that later.

 - check that the documentation is clear enough.

It validates (make check does perform a "make install").
I'm obviously ready to update the patch if necessary (missing files,
other default directories...).

Have a nice day,

--
Fabien Coelho - coelho@cri.ensmp.fr

Attachment

Re: add build utilities in default install

From
Tom Lane
Date:
Fabien COELHO <coelho@cri.ensmp.fr> writes:
> Please find attached my first submission for installing all necessary
> build files (makefile, scripts...) by default.

Why?  They won't do anyone any good outside the original build tree.

Even if modified so that they are useful (which is something that is
on my to-do list), I disagree with installing them by default.  See
previous arguments about installing backend internal headers by default.

            regards, tom lane

Re: add build utilities in default install

From
Fabien COELHO
Date:
Dear Tom,

> > Please find attached my first submission for installing all necessary
> > build files (makefile, scripts...) by default.
>
> Why?  They won't do anyone any good outside the original build tree.

Is your question rhetorical?

So as to allow postgresql extensions (types, functions) to be compiled "as
if"  they would have been compiled in the source tree, as "contrib"s.

> Even if modified so that they are useful (which is something that is
> on my to-do list),

I agree that it is not simple to make them usable "as is".

I'm trying to have a minimum effort solution, but I would be interested in
having a better one, esp. if I don't have to do it myself.

> I disagree with installing them by default. See previous arguments about
> installing backend internal headers by default.


    http://archives.postgresql.org: "Can not connect to search daemon"
    well, my look at previous "archived" arguments will wait.

Anyway, you both forbid extensions to be added within the main
distribution, and to provide help for these extensions to be added from
the outside.

So instead of saying "no", please help us solve the problem: how to make
extensions easilly installable against a postgresql, preferably with
minimum effort from the user who would like to try that?

Under apache, I just do : "apxs -c -i -a mod_foo.c" and it is enough.

If your solution is that extensions should require the sysadmin to fetch
postgresql sources and reconfigure... I disagree. If you have something
better, I'm all ears.

--
Fabien COELHO _ http://www.cri.ensmp.fr/~coelho _ Fabien.Coelho@ensmp.fr
   CRI-ENSMP, 35, rue Saint-Honoré, 77305 Fontainebleau cedex, France
   phone: (+33|0) 1 64 69 {voice: 48 52, fax: 47 09, standard: 47 08}
       ________  All opinions expressed here are mine  _________

Re: add build utilities in default install

From
Fabien COELHO
Date:
Dear patchers,

> Subject: [PATCHES] add build utilities in default install

I withdraw this submission, which was not yet considered for inclusion
anyway.

I'll send a more complete patch, which includes this one, but also provide
a working infrastructure for extensions, sometimes later. I've something
working that needs some finalization and tests.

--
Fabien.

Re: add build utilities in default install

From
Bruce Momjian
Date:
Fabien COELHO wrote:
>
> Dear patchers,
>
> > Subject: [PATCHES] add build utilities in default install
>
> I withdraw this submission, which was not yet considered for inclusion
> anyway.
>
> I'll send a more complete patch, which includes this one, but also provide
> a working infrastructure for extensions, sometimes later. I've something
> working that needs some finalization and tests.

Good, I was wondering were we were on this.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073