Thread: SetDataBaseName
Hi All,
Just a quick question about code changes to 7.4.1. I hope this the right mailing list. If it is not, please point me in the right direction... I am new to these lists.
We have noticed that a function from 7.3.3: SetDataBaseName(const char *name) (in file miscinit.c), and the char *DataBaseName (from globals.c) has been removed in 7.4.1.
Our extension uses this function, so obviously it complained when we tried to apply it and compile. We were wondering is there any particular reason why this function (SetDataBaseName) was taken out? Has it been replaced by another one? Is there any danger in us re-introducing this function to the code(any side affects)?
Thankyou for your help,
Mahesh Swamy
Software Engineer
Fujitsu Australia Software Technology
Address: 14 Rodborough Road, Frenchs Forest NSW 2086
Tel: +61 2 9452 9127
Fax: +61 2 9975 2899
Email: maheshs@fast.fujitsu.com.au
Web site: www.fastware.com
This is an email from Fujitsu Australia Software Technology Pty Ltd, ABN 27 003 693 481. It is confidential to the ordinary user of the email address to which it was addressed and may contain copyright and/or legally privileged information. No one else may read, print, store, copy or forward all or any of it or its attachments. If you receive this email in error, please return to sender. Thank you.
If you do not wish to receive commercial email messages from Fujitsu Australia Software Technology Pty Ltd, please email unsubscribe@fast.fujitsu.com.au
"Mahesh Swamy" <maheshs@fast.fujitsu.com.au> writes:
> We were wondering is there any particular reason why this function
> (SetDataBaseName) was taken out?
Evidently because the variable it sets doesn't exist anymore.
I cannot think of any valid reason for an extension to have been messing
with that variable anyway; so maybe you'd better explain what you need
to accomplish instead of asking a low-level question.
regards, tom lane
Hi Tom, During bootstrap mode, when running initdb, the dabasename template1 is passed in. 741 seems to handle this without using the global variable DatabaseName (which is used in 7.3.3). Our extention still relies on that global variable. So how does 7.4.1 find the database name during bootstrap mode? During bootstrap mode, get_database_name(databaseId) does not seem to work. This is why we are setting the global variable. The databaseId is comming from 7.4.1 code, so we are assuming that is valid. We would like to do it correctly, so any recomendation would be appreciated. Thankyou Mahesh ----- Original Message ----- From: "Tom Lane" <tgl@sss.pgh.pa.us> To: "Mahesh Swamy" <maheshs@fast.fujitsu.com.au> Cc: "osspatches" <pgsql-patches@postgresql.org> Sent: Thursday, May 13, 2004 11:32 PM Subject: Re: [PATCHES] SetDataBaseName > "Mahesh Swamy" <maheshs@fast.fujitsu.com.au> writes: > > We were wondering is there any particular reason why this function > > (SetDataBaseName) was taken out? > > Evidently because the variable it sets doesn't exist anymore. > > I cannot think of any valid reason for an extension to have been messing > with that variable anyway; so maybe you'd better explain what you need > to accomplish instead of asking a low-level question. > > regards, tom lane > This is an email from Fujitsu Australia Software Technology Pty Ltd, ABN 27 003 693 481. It is confidential to the ordinaryuser of the email address to which it was addressed and may contain copyright and/or legally privileged information.No one else may read, print, store, copy or forward all or any of it or its attachments. If you receive thisemail in error, please return to sender. Thank you. If you do not wish to receive commercial email messages from Fujitsu Australia Software Technology Pty Ltd, please emailunsubscribe@fast.fujitsu.com.au
"Mahesh Swamy" <maheshs@fast.fujitsu.com.au> writes:
> So how does 7.4.1 find the database name during bootstrap mode?
I don't think we do. We only really care about the database OID.
regards, tom lane