Thread: win32 fixes
For application to HEAD, following community review.
* Most changes are to fix warnings issued when compiling win32
* removed a few redundant defines
* get_user_name safe under win32
* rationalized pipe read EINTR for win32
* changed all backend instances of sleep() to pg_usleep
- except for the SLEEP_ON_ASSERT in assert.c, as it would exceed a
32-bit long [Note to patcher: If a SLEEP_ON_ASSERT of 2000 seconds is
acceptable, please replace with pg_usleep(2000000000L)]
---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>
Attachment
> * rationalized pipe read EINTR for win32 Should read: * rationalized pipe read EOF for win32 Corrected patch attached. --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see <a href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em ailpolicy.html</a>
Attachment
New version of this patch has been added to the PostgreSQL unapplied
patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
Claudio Natoli wrote:
>
> For application to HEAD, following community review.
>
> * Most changes are to fix warnings issued when compiling win32
> * removed a few redundant defines
> * get_user_name safe under win32
> * rationalized pipe read EINTR for win32
> * changed all backend instances of sleep() to pg_usleep
> - except for the SLEEP_ON_ASSERT in assert.c, as it would exceed a
> 32-bit long [Note to patcher: If a SLEEP_ON_ASSERT of 2000 seconds is
> acceptable, please replace with pg_usleep(2000000000L)]
>
>
>
>
>
>
> ---
> Certain disclaimers and policies apply to all email sent from Memetrics.
> For the full text of these disclaimers and policies see
> <a
> href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
> ailpolicy.html</a>
>
>
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faqs/FAQ.html
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
Newest version of patch applied. Thanks. --------------------------------------------------------------------------- Claudio Natoli wrote: > > For application to HEAD, following community review. > > * Most changes are to fix warnings issued when compiling win32 > * removed a few redundant defines > * get_user_name safe under win32 > * rationalized pipe read EINTR for win32 > * changed all backend instances of sleep() to pg_usleep > - except for the SLEEP_ON_ASSERT in assert.c, as it would exceed a > 32-bit long [Note to patcher: If a SLEEP_ON_ASSERT of 2000 seconds is > acceptable, please replace with pg_usleep(2000000000L)] > > > > > > > --- > Certain disclaimers and policies apply to all email sent from Memetrics. > For the full text of these disclaimers and policies see > <a > href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em > ailpolicy.html</a> > > [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 5: Have you checked our extensive FAQ? > > http://www.postgresql.org/docs/faqs/FAQ.html -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073